[PATCH] sim/MAINTAINERS clarifications.

[PATCH] sim/MAINTAINERS clarifications.

[cgd]

I created the following question after starting to ask the question:

  So, the sim MAINTAINERS file lists maintainers for 'common'.

  Are they assumed to have mastership of sim/igen as well?

  (I'm just wondering who the right person I should pester about a
  quick approval for
  http://sources.redhat.com/ml/gdb-patches/2002-03/msg00055.html,
  since the common part of that is trivial and seems obviously useful,
  to me.  8-)


Assuming the answer to that is "yes," and that the rest of the changes
below are desirable, how about this patch to sim/MAINTAINERS?

(the result is less greppable, but more in the style of the GDB
MAINTAINERS file.)


thanks,

chris
========
2002-03-07  Chris Demetriou  <cgd@broadcom.com>

	* MAINTAINERS: Tweak spacing.  Note write-after-approval
	and obvious fix policies.  Note that "igen" is maintained
	by the maintainers of "common".  Note that "testsuite" bits
	for particular sims are owned by those sims' maintainers.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/sim/MAINTAINERS,v
retrieving revision 1.9
diff -u -r1.9 MAINTAINERS
--- MAINTAINERS	2002/03/06 20:15:53	1.9
+++ MAINTAINERS	2002/03/07 20:24:13
@@ -1,19 +1,29 @@
-		SIM Maintainers
+			   SIM Maintainers
 
 The simulator is part of the GDB project, so see the file
 gdb/MAINTAINERS for general information about maintaining these files.
+(In particular, the same obvious fix and write after approval rules
+apply here.)
 
 If you are considering contributing a patch, please see the file
 gdb/CONTRIBUTE.  Patches to these files should be posted to:
 gdb-patches@sources.redhat.com 
+
 	
-	Maintainers for particular sims:
+	 Maintainers for particular sims and subdirectories:
 
 arm	        Nick Clifton <nickc@redhat.com>
+
 ppc		Andrew Cagney <ac131313@redhat.com>
-ppc		Geoff Keating <geoffk@redhat.com>
+		Geoff Keating <geoffk@redhat.com>
+
 m68hc11		Stephane Carrez <Stephane.Carrez@worldnet.fr>
+
 mips		Andrew Cagney <ac131313@redhat.com>
-mips		Chris Demetriou <cgd@broadcom.com>
-common		Ben Elliston <bje@redhat.com>
-common		Frank Ch. Eigler <fche@redhat.com>
+		Chris Demetriou <cgd@broadcom.com>
+
+common, igen	Ben Elliston <bje@redhat.com>
+		Frank Ch. Eigler <fche@redhat.com>
+
+Sim maintainers are also maintainers of the directories in 'testsuite'
+which correspond to their sims.

Re: [PATCH] sim/MAINTAINERS clarifications.

[Andrew Cagney]

> +common, igen	Ben Elliston <bje@redhat.com>
> +		Frank Ch. Eigler <fche@redhat.com>

I think igen maintenance is better left to the people that need to hack 
on it - mips (ppc if I finished hacking it), mn10300, v850, d10v, d30v, 
??? maintainers.

Andrew

Re: [PATCH] sim/MAINTAINERS clarifications.

[cgd]

At Thu, 07 Mar 2002 17:01:55 -0500, Andrew Cagney wrote:
> > +common, igen	Ben Elliston <bje@redhat.com>
> > +		Frank Ch. Eigler <fche@redhat.com>
> 
> I think igen maintenance is better left to the people that need to hack 
> on it - mips (ppc if I finished hacking it), mn10300, v850, d10v, d30v, 
> ??? maintainers.

actually, looks like currently only:

	mips
	mn10300
	tic80
	v850
	d30v		(mmm, preprocessed by m4!)

use igen.  (i.e., from your list, _not_ d10v.  It uses gencode on
d10v-opc.c, it seems.)

So, anyway, how about the change below?

(If you're prefer to keep things "loose" and relatively un-specified
as they are now, that's fine w/ me, but i figure, hey if this is
the hoped-for policy why not document?  8-)



chris
===================================================================
[ sim/ChangeLog ]
2002-03-07  Chris Demetriou  <cgd@broadcom.com>

	* MAINTAINERS: Tweak spacing.  Note the following:
	write-after-approval and obvious fix policies, "igen" is
	maintained by the maintainers of the sims that use it,
	"testsuite" bits for particular sims are maintained by
	those sims' maintainers.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/sim/MAINTAINERS,v
retrieving revision 1.9
diff -u -r1.9 MAINTAINERS
--- MAINTAINERS	2002/03/06 20:15:53	1.9
+++ MAINTAINERS	2002/03/07 23:54:27
@@ -1,19 +1,35 @@
-		SIM Maintainers
+			   SIM Maintainers
 
 The simulator is part of the GDB project, so see the file
 gdb/MAINTAINERS for general information about maintaining these files.
+(In particular, the same obvious fix and write after approval rules
+apply here.)
 
 If you are considering contributing a patch, please see the file
 gdb/CONTRIBUTE.  Patches to these files should be posted to:
 gdb-patches@sources.redhat.com 
+
 	
-	Maintainers for particular sims:
+Maintainers for particular sims:
 
 arm	        Nick Clifton <nickc@redhat.com>
+
 ppc		Andrew Cagney <ac131313@redhat.com>
-ppc		Geoff Keating <geoffk@redhat.com>
+		Geoff Keating <geoffk@redhat.com>
+
 m68hc11		Stephane Carrez <Stephane.Carrez@worldnet.fr>
+
 mips		Andrew Cagney <ac131313@redhat.com>
-mips		Chris Demetriou <cgd@broadcom.com>
+		Chris Demetriou <cgd@broadcom.com>
+
+
+Maintainers for other subdirectories:
+
 common		Ben Elliston <bje@redhat.com>
-common		Frank Ch. Eigler <fche@redhat.com>
+		Frank Ch. Eigler <fche@redhat.com>
+
+igen		Maintainers for sims that use it.  Currently used
+		by: d30v, mips, mn10300, tic80 v850.
+
+testsuite	Sim maintainers are the maintainers of the directories
+		which correspond to their sims.

Re: [PATCH] sim/MAINTAINERS clarifications.

[Andrew Cagney]

>  (I'm just wondering who the right person I should pester about a
>   quick approval for
>   http://sources.redhat.com/ml/gdb-patches/2002-03/msg00055.html,
>   since the common part of that is trivial and seems obviously useful,
>   to me.  8-)

Sorry, missed it.  I've been assuming that you didn't need approval in 
src/sim.

> +	      else if (strncmp (fmt, "%#lx<", 5) == 0)
> +		/* simple hex with 0x prefix*/
> +		{
> +		  if (pass == 1)
> +		    lf_printf (file, "%%#lx");
> +		  else
> +		    {
> +		      lf_printf (file, "(unsigned long) ");
> +		      lf_write (file, param, strlen_param);
> +		    }
> +		}

``#''? Read man page.  Ah, cute.

The format string should as far as possible look, smell, and even taste 
like fprintf() formats so yes.

Andrew

Re: [PATCH] sim/MAINTAINERS clarifications.

[Andrew Cagney]

BTW, everything on the internet (especially policy stuff) takes at least 
a week.  Moving quickly on this isn't possible.

Andrew