Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfc] Disable [eE] packets by default
Date: Sun, 24 Feb 2002 16:34:00 -0000	[thread overview]
Message-ID: <3C79867F.3000906@cygnus.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

Hello,

This is a followup to the current discussion regarding the [Ee] packets. 
  It disables them by default.

While it is a brutal solution to a problem, it is also 6 days before 5.2 
branches.  It also clears the slate for another attempt at this.

Thoughts?
Andrew

PS: There is no doco patch.  This packet was never documented.  Sigh :-(

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1251 bytes --]

2002-02-24  Andrew Cagney  <ac131313@redhat.com>

	* remote.c (_initialize_remote): By default, disable ``e'' and
	``E'' step out-of-range packets.

Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.76
diff -u -r1.76 remote.c
--- remote.c	2002/02/10 04:08:42	1.76
+++ remote.c	2002/02/25 00:19:23
@@ -6099,6 +6099,10 @@
 			 show_remote_protocol_e_packet_cmd,
 			 &remote_set_cmdlist, &remote_show_cmdlist,
 			 0);
+  /* Disable by default.  The ``e'' packet has nasty interactions with
+     the threading code - it relies on global state.  */
+  remote_protocol_e.detect = CMD_AUTO_BOOLEAN_FALSE;
+  update_packet_config (&remote_protocol_e);
 
   add_packet_config_cmd (&remote_protocol_E,
 			 "E", "step-over-range-w-signal",
@@ -6106,6 +6110,10 @@
 			 show_remote_protocol_E_packet_cmd,
 			 &remote_set_cmdlist, &remote_show_cmdlist,
 			 0);
+  /* Disable by default.  The ``e'' packet has nasty interactions with
+     the threading code - it relies on global state.  */
+  remote_protocol_E.detect = CMD_AUTO_BOOLEAN_FALSE;
+  update_packet_config (&remote_protocol_E);
 
   add_packet_config_cmd (&remote_protocol_P,
 			 "P", "set-register",

             reply	other threads:[~2002-02-25  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-24 16:34 Andrew Cagney [this message]
2002-02-24 16:42 ` Michael Snyder
2002-02-26  9:29   ` Frank Ch. Eigler
2002-02-26 17:23   ` Andrew Cagney
2002-02-26 17:31     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C79867F.3000906@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox