From: Per Bothner <per@bothner.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix PR gdb/265, 64-bit pointers in Java
Date: Wed, 20 Feb 2002 18:11:00 -0000 [thread overview]
Message-ID: <3C74577D.5000503@bothner.com> (raw)
In-Reply-To: <20020220210457.A11990@nevyn.them.org>
Daniel Jacobowitz wrote:
> This look OK? Note the comment.
Perfect.
> - if (type == java_int_type && n > (ULONGEST)0xffffffff)
> - type = java_long_type;
> + /* If the type is bigger than a 32-bit signed integer can be, implicitly
> + promote to long. Java does not do this, so mark it as builtin_type_uint64
> + rather than java_long_type. 0x80000000 will become -0x80000000 instead
> + of 0x80000000L, because we don't know the sign at this point.
> + */
> + if (type == java_int_type && n > (ULONGEST)0x80000000)
> + type = builtin_type_uint64;
--
--Per Bothner
per@bothner.com http://www.bothner.com/per/
next prev parent reply other threads:[~2002-02-21 2:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-10 21:38 Daniel Jacobowitz
2002-02-11 10:24 ` Tom Tromey
2002-02-11 10:31 ` Daniel Jacobowitz
2002-02-20 14:41 ` Daniel Jacobowitz
2002-02-20 15:04 ` Per Bothner
2002-02-20 15:44 ` Daniel Jacobowitz
2002-02-20 17:30 ` Per Bothner
2002-02-20 18:05 ` Daniel Jacobowitz
2002-02-20 18:11 ` Per Bothner [this message]
2002-02-20 18:55 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C74577D.5000503@bothner.com \
--to=per@bothner.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox