From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29196 invoked by alias); 21 Feb 2002 02:11:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29012 invoked from network); 21 Feb 2002 02:11:32 -0000 Received: from unknown (HELO bothner.com) (216.102.199.253) by sources.redhat.com with SMTP; 21 Feb 2002 02:11:32 -0000 Received: from bothner.com (eureka.bothner.com [192.168.1.9]) by bothner.com (8.11.6/8.11.6) with ESMTP id g1L2Fvp03109; Wed, 20 Feb 2002 18:15:57 -0800 Message-ID: <3C74577D.5000503@bothner.com> Date: Wed, 20 Feb 2002 18:11:00 -0000 From: Per Bothner User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8+) Gecko/20020215 X-Accept-Language: en-us MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: Fix PR gdb/265, 64-bit pointers in Java References: <20020211003818.A26546@nevyn.them.org> <20020220174154.A29999@nevyn.them.org> <3C742B97.2060609@bothner.com> <20020220184414.A7963@nevyn.them.org> <3C744DC0.1090902@bothner.com> <20020220210457.A11990@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00582.txt.bz2 Daniel Jacobowitz wrote: > This look OK? Note the comment. Perfect. > - if (type == java_int_type && n > (ULONGEST)0xffffffff) > - type = java_long_type; > + /* If the type is bigger than a 32-bit signed integer can be, implicitly > + promote to long. Java does not do this, so mark it as builtin_type_uint64 > + rather than java_long_type. 0x80000000 will become -0x80000000 instead > + of 0x80000000L, because we don't know the sign at this point. > + */ > + if (type == java_int_type && n > (ULONGEST)0x80000000) > + type = builtin_type_uint64; -- --Per Bothner per@bothner.com http://www.bothner.com/per/