Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH ARM support a multi-arch compatible way of doing call dummys
Date: Mon, 18 Feb 2002 09:53:00 -0000	[thread overview]
Message-ID: <3C713FAF.2090001@cygnus.com> (raw)
In-Reply-To: <200202181646.QAA07618@cam-mail2.cambridge.arm.com>

> +    XXX Tweeking current_gdbarch is not an optimal solution, but the
> +    call to arm_fix_call_dummy is immediately followed by a call to
> +    run_stack_dummy, which is the only function where
> +    call_dummy_breakpoint_offset is actually used.  */
> 

Just an aside, a fairly standard GDB convention is:

	FIXME: cagney/2002-02-18: ..
or 
NOTE: cagney/2002-02-18: ...

so that N years down the track people have a rough idea as to the age 
and origins of a comment are.  (The fixme isn't an indication of who 
intends fixing it :-)

enjoy,
Andrew



      reply	other threads:[~2002-02-18 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-18  8:47 Richard Earnshaw
2002-02-18  9:53 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C713FAF.2090001@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox