From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6729 invoked by alias); 18 Feb 2002 17:53:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6646 invoked from network); 18 Feb 2002 17:53:51 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 18 Feb 2002 17:53:51 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 94E683D0D; Mon, 18 Feb 2002 12:53:51 -0500 (EST) Message-ID: <3C713FAF.2090001@cygnus.com> Date: Mon, 18 Feb 2002 09:53:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Richard.Earnshaw@arm.com Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH ARM support a multi-arch compatible way of doing call dummys References: <200202181646.QAA07618@cam-mail2.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00476.txt.bz2 > + XXX Tweeking current_gdbarch is not an optimal solution, but the > + call to arm_fix_call_dummy is immediately followed by a call to > + run_stack_dummy, which is the only function where > + call_dummy_breakpoint_offset is actually used. */ > Just an aside, a fairly standard GDB convention is: FIXME: cagney/2002-02-18: .. or NOTE: cagney/2002-02-18: ... so that N years down the track people have a rough idea as to the age and origins of a comment are. (The fixme isn't an indication of who intends fixing it :-) enjoy, Andrew