Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] gdbserver 1/3 - top level config
Date: Wed, 13 Feb 2002 20:20:00 -0000	[thread overview]
Message-ID: <3C6B3B1D.5060704@cygnus.com> (raw)
In-Reply-To: <20020205174549.A13231@nevyn.them.org>


> -# these really aren't orthogonal true/false values of the same condition,
> -# but shells are slow enough that I like to reuse the test conditions
> -# whenever possible

Yes, the comment was silly.

However a comment indicating that the NATIVE info is picked up from the 
HOST (.mh) file because there is no NATIVE (.mn) file would be useful.

>  if test "${target}" = "${host}"; then
>  nativefile=`sed -n '
>  s/NAT_FILE[ 	]*=[ 	]*\([^ 	]*\)/\1/p
>  ' ${host_makefile_frag}`
> -# else
> -# GDBserver is only useful in a "native" environment
> -# configdirs=`echo $configdirs | sed 's/gdbserver//'`
>  fi
>  changequote([,])
>  
> @@ -1277,10 +1271,16 @@
>      *)  AC_MSG_ERROR("GDB: Unknown GDB_MULTI_ARCH value ${GDB_MULTI_ARCH}");;
>  esac
>  
> -
>  SUBDIRS="doc testsuite nlm"
>  if test "${enable_multi_ice}" = "yes"; then
>    SUBDIRS="${SUBDIRS} multi-ice"
> +fi

> +if test x"${target}" = x"${host}"; then
> +    if test x"${build_gdbserver}" = xyes ; then
> +	configdirs="${configdirs} gdbserver"
> +	SUBDIRS="${SUBDIRS} gdbserver"
> +    fi

v.good move.  make it clear that the condition is separate/independant. 
  Can I again suggest a comment explaining why.  Is it possible to print 
an info message?

ok with me.
Andrew



  parent reply	other threads:[~2002-02-14  4:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-05 14:46 Daniel Jacobowitz
2002-02-06 16:34 ` Daniel Jacobowitz
2002-02-13 12:10   ` Daniel Jacobowitz
2002-02-13 20:20 ` Andrew Cagney [this message]
2002-02-13 21:32   ` Daniel Jacobowitz
2002-02-13 21:33     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C6B3B1D.5060704@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox