From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-12775-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 26754 invoked by alias); 14 Feb 2002 04:20:48 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26708 invoked from network); 14 Feb 2002 04:20:47 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.135.44)
  by sources.redhat.com with SMTP; 14 Feb 2002 04:20:47 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 0070A3CC5; Wed, 13 Feb 2002 23:20:45 -0500 (EST)
Message-ID: <3C6B3B1D.5060704@cygnus.com>
Date: Wed, 13 Feb 2002 20:20:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210
X-Accept-Language: en-us
MIME-Version: 1.0
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] gdbserver 1/3 - top level config
References: <20020205174549.A13231@nevyn.them.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-02/txt/msg00390.txt.bz2


> -# these really aren't orthogonal true/false values of the same condition,
> -# but shells are slow enough that I like to reuse the test conditions
> -# whenever possible

Yes, the comment was silly.

However a comment indicating that the NATIVE info is picked up from the 
HOST (.mh) file because there is no NATIVE (.mn) file would be useful.

>  if test "${target}" = "${host}"; then
>  nativefile=`sed -n '
>  s/NAT_FILE[ 	]*=[ 	]*\([^ 	]*\)/\1/p
>  ' ${host_makefile_frag}`
> -# else
> -# GDBserver is only useful in a "native" environment
> -# configdirs=`echo $configdirs | sed 's/gdbserver//'`
>  fi
>  changequote([,])
>  
> @@ -1277,10 +1271,16 @@
>      *)  AC_MSG_ERROR("GDB: Unknown GDB_MULTI_ARCH value ${GDB_MULTI_ARCH}");;
>  esac
>  
> -
>  SUBDIRS="doc testsuite nlm"
>  if test "${enable_multi_ice}" = "yes"; then
>    SUBDIRS="${SUBDIRS} multi-ice"
> +fi

> +if test x"${target}" = x"${host}"; then
> +    if test x"${build_gdbserver}" = xyes ; then
> +	configdirs="${configdirs} gdbserver"
> +	SUBDIRS="${SUBDIRS} gdbserver"
> +    fi

v.good move.  make it clear that the condition is separate/independant. 
  Can I again suggest a comment explaining why.  Is it possible to print 
an info message?

ok with me.
Andrew