* [PATCH] Add alpha target to asm-source.exp test
@ 2002-02-07 14:16 Kuppuswamy, Priyadarshini
2002-02-07 14:32 ` Michael Snyder
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Kuppuswamy, Priyadarshini @ 2002-02-07 14:16 UTC (permalink / raw)
To: gdb-patches; +Cc: clp
Hi!
This is the asm-source test for the alpha target.
Let me know if this is ok??
--Priya
The new file "alpha.inc" is included at the end.
*gdb.asm/alpha.inc: New file.
*gdb.asm/asm-source.exp: Recognize the alpha target *gdb.asm/configure.in: Recognize the alpha target *gdb.asm/configure:Regenerate.
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
retrieving revision 1.8
diff -c -3 -p -r1.8 configure.in
*** configure.in 2001/12/20 22:12:20 1.8
--- configure.in 2002/02/07 21:31:36
*************** archinc=common.inc
*** 17,22 ****
--- 17,23 ----
case ${target} in
*arm-*-*) archinc=arm.inc ;;
xscale-*-*) archinc=arm.inc ;;
+ alpha*-*-*) archinc=alpha.inc ;;
d10v-*-*) archinc=d10v.inc ;;
s390-*-*) archinc=s390.inc ;;
i[[3456]]86*) archinc=i386.inc ;;
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
retrieving revision 1.8
diff -c -3 -p -r1.8 configure
*** configure 2001/12/20 22:12:20 1.8
--- configure 2002/02/07 21:32:09
*************** archinc=common.inc
*** 637,642 ****
--- 637,643 ----
case ${target} in
*arm-*-*) archinc=arm.inc ;;
xscale-*-*) archinc=arm.inc ;;
+ alpha*-*-*) archinc=alpha.inc ;;
d10v-*-*) archinc=d10v.inc ;;
s390-*-*) archinc=s390.inc ;;
i[3456]86*) archinc=i386.inc ;;
Index: asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.17
diff -c -3 -p -r1.17 asm-source.exp
*** asm-source.exp 2002/01/18 00:13:00 1.17
--- asm-source.exp 2002/02/07 21:32:27
*************** if [istarget "*arm-*-*"] then {
*** 41,46 ****
--- 41,50 ----
if [istarget "xscale-*-*"] then {
set asm-arch arm
}
+ if [istarget "alpha*-*-*"] then {
+ set asm-arch alpha
+ set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
+ }
if [istarget "d10v-*-*"] then {
set asm-arch d10v
}
alpha.inc
---------
comment "subroutine prologue"
.macro gdbasm_enter
subq $30,32,$30
stq $26,0($30)
stq $15,8($30)
bis $30,$30,$15
.endm
comment "subroutine epilogue"
.macro gdbasm_leave
bis $15,$15,$30
ldq $26,0($30)
ldq $15,8($30)
addq $30,32,$30
ret $31,($26),1
.endm
.macro gdbasm_call subr
bsr $26, \subr
.endm
.macro gdbasm_several_nops
nop
nop
nop
nop
.endm
comment "exit (0)"
.macro gdbasm_exit0
halt
.endm
comment "crt0 startup"
.macro gdbasm_startup
clr $fp
.endm
comment "Declare a data variable"
.macro gdbasm_datavar name value
.data
\name:
.long \value
.endm
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 14:16 [PATCH] Add alpha target to asm-source.exp test Kuppuswamy, Priyadarshini
@ 2002-02-07 14:32 ` Michael Snyder
2002-02-07 14:52 ` Fernando Nasser
2002-02-07 15:18 ` George France
2002-03-23 11:18 ` Andrew Cagney
2 siblings, 1 reply; 12+ messages in thread
From: Michael Snyder @ 2002-02-07 14:32 UTC (permalink / raw)
To: Kuppuswamy, Priyadarshini; +Cc: gdb-patches, clp, fnasser
"Kuppuswamy, Priyadarshini" wrote:
>
> Hi!
>
> This is the asm-source test for the alpha target.
>
> Let me know if this is ok??
>
> --Priya
>
> The new file "alpha.inc" is included at the end.
I was working on this myself a month or so ago, and
the assembly language that you came up with looks very
similar to mine. So I'll give yours a technical endorsement,
while waiting for Fernando to give the official approval.
>
> *gdb.asm/alpha.inc: New file.
> *gdb.asm/asm-source.exp: Recognize the alpha target *gdb.asm/configure.in: Recognize the alpha target *gdb.asm/configure:Regenerate.
>
> Index: configure.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
> retrieving revision 1.8
> diff -c -3 -p -r1.8 configure.in
> *** configure.in 2001/12/20 22:12:20 1.8
> --- configure.in 2002/02/07 21:31:36
> *************** archinc=common.inc
> *** 17,22 ****
> --- 17,23 ----
> case ${target} in
> *arm-*-*) archinc=arm.inc ;;
> xscale-*-*) archinc=arm.inc ;;
> + alpha*-*-*) archinc=alpha.inc ;;
> d10v-*-*) archinc=d10v.inc ;;
> s390-*-*) archinc=s390.inc ;;
> i[[3456]]86*) archinc=i386.inc ;;
>
> Index: configure
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
> retrieving revision 1.8
> diff -c -3 -p -r1.8 configure
> *** configure 2001/12/20 22:12:20 1.8
> --- configure 2002/02/07 21:32:09
> *************** archinc=common.inc
> *** 637,642 ****
> --- 637,643 ----
> case ${target} in
> *arm-*-*) archinc=arm.inc ;;
> xscale-*-*) archinc=arm.inc ;;
> + alpha*-*-*) archinc=alpha.inc ;;
> d10v-*-*) archinc=d10v.inc ;;
> s390-*-*) archinc=s390.inc ;;
> i[3456]86*) archinc=i386.inc ;;
>
> Index: asm-source.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.17
> diff -c -3 -p -r1.17 asm-source.exp
> *** asm-source.exp 2002/01/18 00:13:00 1.17
> --- asm-source.exp 2002/02/07 21:32:27
> *************** if [istarget "*arm-*-*"] then {
> *** 41,46 ****
> --- 41,50 ----
> if [istarget "xscale-*-*"] then {
> set asm-arch arm
> }
> + if [istarget "alpha*-*-*"] then {
> + set asm-arch alpha
> + set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> + }
> if [istarget "d10v-*-*"] then {
> set asm-arch d10v
> }
>
> alpha.inc
> ---------
> comment "subroutine prologue"
> .macro gdbasm_enter
> subq $30,32,$30
> stq $26,0($30)
> stq $15,8($30)
> bis $30,$30,$15
> .endm
>
> comment "subroutine epilogue"
> .macro gdbasm_leave
> bis $15,$15,$30
> ldq $26,0($30)
> ldq $15,8($30)
> addq $30,32,$30
> ret $31,($26),1
> .endm
>
> .macro gdbasm_call subr
> bsr $26, \subr
> .endm
>
> .macro gdbasm_several_nops
> nop
> nop
> nop
> nop
> .endm
>
> comment "exit (0)"
> .macro gdbasm_exit0
> halt
> .endm
>
> comment "crt0 startup"
> .macro gdbasm_startup
> clr $fp
> .endm
>
> comment "Declare a data variable"
> .macro gdbasm_datavar name value
> .data
> \name:
> .long \value
> .endm
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 14:32 ` Michael Snyder
@ 2002-02-07 14:52 ` Fernando Nasser
0 siblings, 0 replies; 12+ messages in thread
From: Fernando Nasser @ 2002-02-07 14:52 UTC (permalink / raw)
To: Michael Snyder; +Cc: Kuppuswamy, Priyadarshini, gdb-patches, clp
Michael Snyder wrote:
>
> "Kuppuswamy, Priyadarshini" wrote:
> >
> > Hi!
> >
> > This is the asm-source test for the alpha target.
> >
> > Let me know if this is ok??
> >
> > --Priya
> >
> > The new file "alpha.inc" is included at the end.
>
> I was working on this myself a month or so ago, and
> the assembly language that you came up with looks very
> similar to mine. So I'll give yours a technical endorsement,
> while waiting for Fernando to give the official approval.
>
Hi Kuppuswamy,
Do you have a FSF assignment?
Fernando
> >
> > *gdb.asm/alpha.inc: New file.
> > *gdb.asm/asm-source.exp: Recognize the alpha target *gdb.asm/configure.in: Recognize the alpha target *gdb.asm/configure:Regenerate.
> >
> > Index: configure.in
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
> > retrieving revision 1.8
> > diff -c -3 -p -r1.8 configure.in
> > *** configure.in 2001/12/20 22:12:20 1.8
> > --- configure.in 2002/02/07 21:31:36
> > *************** archinc=common.inc
> > *** 17,22 ****
> > --- 17,23 ----
> > case ${target} in
> > *arm-*-*) archinc=arm.inc ;;
> > xscale-*-*) archinc=arm.inc ;;
> > + alpha*-*-*) archinc=alpha.inc ;;
> > d10v-*-*) archinc=d10v.inc ;;
> > s390-*-*) archinc=s390.inc ;;
> > i[[3456]]86*) archinc=i386.inc ;;
> >
> > Index: configure
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
> > retrieving revision 1.8
> > diff -c -3 -p -r1.8 configure
> > *** configure 2001/12/20 22:12:20 1.8
> > --- configure 2002/02/07 21:32:09
> > *************** archinc=common.inc
> > *** 637,642 ****
> > --- 637,643 ----
> > case ${target} in
> > *arm-*-*) archinc=arm.inc ;;
> > xscale-*-*) archinc=arm.inc ;;
> > + alpha*-*-*) archinc=alpha.inc ;;
> > d10v-*-*) archinc=d10v.inc ;;
> > s390-*-*) archinc=s390.inc ;;
> > i[3456]86*) archinc=i386.inc ;;
> >
> > Index: asm-source.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> > retrieving revision 1.17
> > diff -c -3 -p -r1.17 asm-source.exp
> > *** asm-source.exp 2002/01/18 00:13:00 1.17
> > --- asm-source.exp 2002/02/07 21:32:27
> > *************** if [istarget "*arm-*-*"] then {
> > *** 41,46 ****
> > --- 41,50 ----
> > if [istarget "xscale-*-*"] then {
> > set asm-arch arm
> > }
> > + if [istarget "alpha*-*-*"] then {
> > + set asm-arch alpha
> > + set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> > + }
> > if [istarget "d10v-*-*"] then {
> > set asm-arch d10v
> > }
> >
> > alpha.inc
> > ---------
> > comment "subroutine prologue"
> > .macro gdbasm_enter
> > subq $30,32,$30
> > stq $26,0($30)
> > stq $15,8($30)
> > bis $30,$30,$15
> > .endm
> >
> > comment "subroutine epilogue"
> > .macro gdbasm_leave
> > bis $15,$15,$30
> > ldq $26,0($30)
> > ldq $15,8($30)
> > addq $30,32,$30
> > ret $31,($26),1
> > .endm
> >
> > .macro gdbasm_call subr
> > bsr $26, \subr
> > .endm
> >
> > .macro gdbasm_several_nops
> > nop
> > nop
> > nop
> > nop
> > .endm
> >
> > comment "exit (0)"
> > .macro gdbasm_exit0
> > halt
> > .endm
> >
> > comment "crt0 startup"
> > .macro gdbasm_startup
> > clr $fp
> > .endm
> >
> > comment "Declare a data variable"
> > .macro gdbasm_datavar name value
> > .data
> > \name:
> > .long \value
> > .endm
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 14:16 [PATCH] Add alpha target to asm-source.exp test Kuppuswamy, Priyadarshini
2002-02-07 14:32 ` Michael Snyder
@ 2002-02-07 15:18 ` George France
2002-02-07 19:30 ` Daniel Jacobowitz
2002-03-23 11:18 ` Andrew Cagney
2002-03-23 11:18 ` Andrew Cagney
2 siblings, 2 replies; 12+ messages in thread
From: George France @ 2002-02-07 15:18 UTC (permalink / raw)
To: Kuppuswamy, Priyadarshini, gdb-patches; +Cc: clp
Hello Priya,
I like your patch. It makes sense to me, but I have one question, in the
code below. You are setting the asm-flags to '-gdwaft2'. I would assume
that this is because '-g' is broken???? If '-g' is broken, shouldn't this be
two tests??? One with '-g'. One with '-gdwarf2'.
Best Regards,
--George
On Thursday 07 February 2002 17:16, Kuppuswamy, Priyadarshini wrote:
> + if [istarget "alpha*-*-*"] then {
> + set asm-arch alpha
> + set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> + }
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 15:18 ` George France
@ 2002-02-07 19:30 ` Daniel Jacobowitz
2002-02-08 10:44 ` Michael Snyder
2002-03-23 11:18 ` Andrew Cagney
1 sibling, 1 reply; 12+ messages in thread
From: Daniel Jacobowitz @ 2002-02-07 19:30 UTC (permalink / raw)
To: George France; +Cc: Kuppuswamy, Priyadarshini, gdb-patches, clp
On Thu, Feb 07, 2002 at 06:10:34PM -0500, George France wrote:
> Hello Priya,
>
> I like your patch. It makes sense to me, but I have one question, in the
> code below. You are setting the asm-flags to '-gdwaft2'. I would assume
> that this is because '-g' is broken???? If '-g' is broken, shouldn't this be
> two tests??? One with '-g'. One with '-gdwarf2'.
There's no point in testing -g on Alpha; -g defaults to stabs, and
stabs have never worked on 64-bit systems.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 19:30 ` Daniel Jacobowitz
@ 2002-02-08 10:44 ` Michael Snyder
2002-02-11 11:58 ` George France
0 siblings, 1 reply; 12+ messages in thread
From: Michael Snyder @ 2002-02-08 10:44 UTC (permalink / raw)
To: Daniel Jacobowitz
Cc: George France, Kuppuswamy, Priyadarshini, gdb-patches, clp
Daniel Jacobowitz wrote:
>
> On Thu, Feb 07, 2002 at 06:10:34PM -0500, George France wrote:
> > Hello Priya,
> >
> > I like your patch. It makes sense to me, but I have one question, in the
> > code below. You are setting the asm-flags to '-gdwaft2'. I would assume
> > that this is because '-g' is broken???? If '-g' is broken, shouldn't this be
> > two tests??? One with '-g'. One with '-gdwarf2'.
>
> There's no point in testing -g on Alpha; -g defaults to stabs, and
> stabs have never worked on 64-bit systems.
-g defaults to whatever it's configured to default to.
If alpha is 64 bit, then alpha should be configured to
default to dwarf-2.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-08 10:44 ` Michael Snyder
@ 2002-02-11 11:58 ` George France
0 siblings, 0 replies; 12+ messages in thread
From: George France @ 2002-02-11 11:58 UTC (permalink / raw)
To: Michael Snyder, Daniel Jacobowitz
Cc: Kuppuswamy, Priyadarshini, gdb-patches, clp
Hello Michael,
I was in a rush last week when I sent the e-mail and I was not very clear.
Let me try again.
I know that stabs is broken on alpha. My question is more of a QA question.
Should the testsuite rely on the default configuration of the system that
the test is being ran upon???? I believe that relying upon the default
configuration produces inconsistent testsuite results.
Shouldn't stabs and dwarf2 be tested on all the architectures???? This
would create consistent testsuite results. In the case of stabs on alpha,
since we know that it is broken, the result that I would expect is XFAIL.
I will not have time to write a patch that would test both stabs and dwarf2
for at least a week, but I would like to solve this problem and have
consistent testsuite results.
I hope this clarifies things.
Best Regards,
--George
On Friday 08 February 2002 13:36, Michael Snyder wrote:
> Daniel Jacobowitz wrote:
> > On Thu, Feb 07, 2002 at 06:10:34PM -0500, George France wrote:
> > > Hello Priya,
> > >
> > > I like your patch. It makes sense to me, but I have one question, in
> > > the code below. You are setting the asm-flags to '-gdwaft2'. I would
> > > assume that this is because '-g' is broken???? If '-g' is broken,
> > > shouldn't this be two tests??? One with '-g'. One with '-gdwarf2'.
> >
> > There's no point in testing -g on Alpha; -g defaults to stabs, and
> > stabs have never worked on 64-bit systems.
>
> -g defaults to whatever it's configured to default to.
> If alpha is 64 bit, then alpha should be configured to
> default to dwarf-2.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 15:18 ` George France
2002-02-07 19:30 ` Daniel Jacobowitz
@ 2002-03-23 11:18 ` Andrew Cagney
1 sibling, 0 replies; 12+ messages in thread
From: Andrew Cagney @ 2002-03-23 11:18 UTC (permalink / raw)
To: George France; +Cc: Kuppuswamy, Priyadarshini, gdb-patches, clp
> Hello Priya,
>
> I like your patch. It makes sense to me, but I have one question, in the
> code below. You are setting the asm-flags to '-gdwaft2'. I would assume
> that this is because '-g' is broken???? If '-g' is broken, shouldn't this be
> two tests??? One with '-g'. One with '-gdwarf2'.
>
> Best Regards,
The convention I believe gdb.asm has adopted is for each architecture to
specify the debug format that that architecture's users are expected to
use and is considered ``supported''.
enjoy,
Andrew
> --George
>
> On Thursday 07 February 2002 17:16, Kuppuswamy, Priyadarshini wrote:
>
>> + if [istarget "alpha*-*-*"] then {
>> + set asm-arch alpha
>> + set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
>> + }
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add alpha target to asm-source.exp test
2002-02-07 14:16 [PATCH] Add alpha target to asm-source.exp test Kuppuswamy, Priyadarshini
2002-02-07 14:32 ` Michael Snyder
2002-02-07 15:18 ` George France
@ 2002-03-23 11:18 ` Andrew Cagney
2 siblings, 0 replies; 12+ messages in thread
From: Andrew Cagney @ 2002-03-23 11:18 UTC (permalink / raw)
To: Kuppuswamy, Priyadarshini; +Cc: gdb-patches, clp
Hello,
Can I suggest re-submitting your alpha patch, your assignment has come
in so it can now be properly reviewed by the testsuite maintainer.
Andrew
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] Add alpha target to asm-source.exp test
@ 2002-03-25 11:47 Kuppuswamy, Priyadarshini
2002-03-28 12:58 ` Fernando Nasser
0 siblings, 1 reply; 12+ messages in thread
From: Kuppuswamy, Priyadarshini @ 2002-03-25 11:47 UTC (permalink / raw)
To: Andrew Cagney, gdb-patches; +Cc: clp
Hi,
I am re-submitting the alpha patch since I finally got the permission to do so.
Index: asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.18
diff -u -p -r1.18 asm-source.exp
--- asm-source.exp 2002/02/21 20:58:25 1.18
+++ asm-source.exp 2002/03/25 19:33:12
@@ -41,6 +41,11 @@ if [istarget "*arm-*-*"] then {
if [istarget "xscale-*-*"] then {
set asm-arch arm
}
+if [istarget "alpha*-*-*"] then {
+ set asm-arch alpha
+ set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
+}
if [istarget "d10v-*-*"] then {
set asm-arch d10v
}
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
retrieving revision 1.8
diff -u -p -r1.8 configure
--- configure 2001/12/20 22:12:20 1.8
+++ configure 2002/03/25 19:34:11
@@ -637,6 +637,7 @@ archinc=common.inc
case ${target} in
*arm-*-*) archinc=arm.inc ;;
xscale-*-*) archinc=arm.inc ;;
+alpha*-*-*) archinc=alpha.inc ;;
d10v-*-*) archinc=d10v.inc ;;
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
retrieving revision 1.8
diff -u -p -r1.8 configure.in
--- configure.in 2001/12/20 22:12:20 1.8
+++ configure.in 2002/03/25 19:34:37
@@ -17,6 +17,7 @@ archinc=common.inc
case ${target} in
*arm-*-*) archinc=arm.inc ;;
xscale-*-*) archinc=arm.inc ;;
+alpha*-*-*) archinc=alpha.inc ;;
d10v-*-*) archinc=d10v.inc ;;
(new file) alpha.inc
---------------------
comment "subroutine prologue"
.macro gdbasm_enter
subq $30,32,$30
stq $26,0($30)
stq $15,8($30)
bis $30,$30,$15
.endm
comment "subroutine epilogue"
.macro gdbasm_leave
bis $15,$15,$30
ldq $26,0($30)
ldq $15,8($30)
addq $30,32,$30
ret $31,($26),1
.endm
.macro gdbasm_call subr
bsr $26, \subr
.endm
.macro gdbasm_several_nops
nop
nop
nop
nop
.endm
comment "exit (0)"
.macro gdbasm_exit0
halt
.endm
comment "crt0 startup"
.macro gdbasm_startup
clr $fp
.endm
comment "Declare a data variable"
.macro gdbasm_datavar name value
.data
\name:
.long \value
.endm
Thanks
Priya
> -----Original Message-----
> From: Andrew Cagney [mailto:ac131313@cygnus.com]
> Sent: Saturday, March 23, 2002 2:19 PM
> To: Kuppuswamy, Priyadarshini
> Cc: gdb-patches@sources.redhat.com; clp@iol.unh.edu
> Subject: Re: [PATCH] Add alpha target to asm-source.exp test
>
>
> Hello,
>
> Can I suggest re-submitting your alpha patch, your assignment
> has come
> in so it can now be properly reviewed by the testsuite maintainer.
>
> Andrew
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add alpha target to asm-source.exp test
2002-03-25 11:47 Kuppuswamy, Priyadarshini
@ 2002-03-28 12:58 ` Fernando Nasser
0 siblings, 0 replies; 12+ messages in thread
From: Fernando Nasser @ 2002-03-28 12:58 UTC (permalink / raw)
To: Kuppuswamy, Priyadarshini; +Cc: Andrew Cagney, gdb-patches, clp
"Kuppuswamy, Priyadarshini" wrote:
>
> Hi,
> I am re-submitting the alpha patch since I finally got the permission to do so.
>
Thanks for the patch. As soon as you get your cvs access please check it in.
Regards,
Fernando
> Index: asm-source.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.18
> diff -u -p -r1.18 asm-source.exp
> --- asm-source.exp 2002/02/21 20:58:25 1.18
> +++ asm-source.exp 2002/03/25 19:33:12
> @@ -41,6 +41,11 @@ if [istarget "*arm-*-*"] then {
> if [istarget "xscale-*-*"] then {
> set asm-arch arm
> }
> +if [istarget "alpha*-*-*"] then {
> + set asm-arch alpha
> + set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> +}
> if [istarget "d10v-*-*"] then {
> set asm-arch d10v
> }
>
> Index: configure
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
> retrieving revision 1.8
> diff -u -p -r1.8 configure
> --- configure 2001/12/20 22:12:20 1.8
> +++ configure 2002/03/25 19:34:11
> @@ -637,6 +637,7 @@ archinc=common.inc
> case ${target} in
> *arm-*-*) archinc=arm.inc ;;
> xscale-*-*) archinc=arm.inc ;;
> +alpha*-*-*) archinc=alpha.inc ;;
> d10v-*-*) archinc=d10v.inc ;;
>
>
> Index: configure.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
> retrieving revision 1.8
> diff -u -p -r1.8 configure.in
> --- configure.in 2001/12/20 22:12:20 1.8
> +++ configure.in 2002/03/25 19:34:37
> @@ -17,6 +17,7 @@ archinc=common.inc
> case ${target} in
> *arm-*-*) archinc=arm.inc ;;
> xscale-*-*) archinc=arm.inc ;;
> +alpha*-*-*) archinc=alpha.inc ;;
> d10v-*-*) archinc=d10v.inc ;;
>
> (new file) alpha.inc
> ---------------------
> comment "subroutine prologue"
> .macro gdbasm_enter
> subq $30,32,$30
> stq $26,0($30)
> stq $15,8($30)
> bis $30,$30,$15
> .endm
>
> comment "subroutine epilogue"
> .macro gdbasm_leave
> bis $15,$15,$30
> ldq $26,0($30)
> ldq $15,8($30)
> addq $30,32,$30
> ret $31,($26),1
> .endm
>
> .macro gdbasm_call subr
> bsr $26, \subr
> .endm
>
> .macro gdbasm_several_nops
> nop
> nop
> nop
> nop
> .endm
>
> comment "exit (0)"
> .macro gdbasm_exit0
> halt
> .endm
>
> comment "crt0 startup"
> .macro gdbasm_startup
> clr $fp
> .endm
>
> comment "Declare a data variable"
> .macro gdbasm_datavar name value
> .data
> \name:
> .long \value
> .endm
>
> Thanks
> Priya
>
> > -----Original Message-----
> > From: Andrew Cagney [mailto:ac131313@cygnus.com]
> > Sent: Saturday, March 23, 2002 2:19 PM
> > To: Kuppuswamy, Priyadarshini
> > Cc: gdb-patches@sources.redhat.com; clp@iol.unh.edu
> > Subject: Re: [PATCH] Add alpha target to asm-source.exp test
> >
> >
> > Hello,
> >
> > Can I suggest re-submitting your alpha patch, your assignment
> > has come
> > in so it can now be properly reviewed by the testsuite maintainer.
> >
> > Andrew
> >
> >
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] Add alpha target to asm-source.exp test
@ 2002-03-29 12:39 Kuppuswamy, Priyadarshini
0 siblings, 0 replies; 12+ messages in thread
From: Kuppuswamy, Priyadarshini @ 2002-03-29 12:39 UTC (permalink / raw)
To: gdb-patches; +Cc: andrew.cagney
I've added myself to the MAINTAINERS write after approval list and also made chagnes to the changeLog. I've submitted the patch as an obvious fix.
Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.163
diff -p -c -r1.163 MAINTAINERS
*** MAINTAINERS 2002/03/23 18:52:46 1.163
--- MAINTAINERS 2002/03/29 18:02:43
*************** Jason Merrill jason@redhat.com
*** 376,381 ****
--- 376,382 ----
Jason Molenda jmolenda@apple.com
Pierre Muller muller@sources.redhat.com
Alexandre Oliva aoliva@redhat.com
+ Kuppuswamy Priyadarshini priyadarshini.kuppuswamy@compaq.com
Tom Rix trix@redhat.com
Mark Salter msalter@redhat.com
Andreas Schwab schwab@suse.de
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.2364
diff -u -p -r1.2364 ChangeLog
--- ChangeLog 2002/03/29 01:32:19 1.2364
+++ ChangeLog 2002/03/29 20:32:51
@@ -1,3 +1,7 @@
+2002-03-29 Priyadarshini Kuppuswamy <priyadarshini.kuppuswamy@compaq.com>
+
+ * MAINTAINERS (write-after-approval): Add myself.
+
2002-03-26 Michael Snyder <msnyder@redhat.com>
Andrew Cagney <cagney@redhat.com>
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.292
diff -u -p -r1.292 ChangeLog
--- ChangeLog 2002/03/29 01:19:11 1.292
+++ ChangeLog 2002/03/29 20:35:32
@@ -1,3 +1,10 @@
+2002-03-29 Priyadarshini Kuppuswamy <priyadarshini.kuppuswamy@compaq.com>
+
+ * gdb.asm/alpha.inc: New file.
+ * gdb.asm/asm-source.exp: Recognize alpha target.
+ * gdb.asm/configure.in: Recognize alpha target.
+ * gdb.asm/configure: Regenerate.
+
2002-03-26 Michael Snyder <msnyder@redhat.com>
* gdb.base/default.exp: Add tests for dump, append, and restore.
Priya.
> -----Original Message-----
> From: Kuppuswamy, Priyadarshini
> Sent: Monday, March 25, 2002 2:47 PM
> To: 'Andrew Cagney'; gdb-patches@sources.redhat.com
> Cc: clp@iol.unh.edu
> Subject: RE: [PATCH] Add alpha target to asm-source.exp test
>
>
> Hi,
> I am re-submitting the alpha patch since I finally got the
> permission to do so.
>
> Index: asm-source.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.18
> diff -u -p -r1.18 asm-source.exp
> --- asm-source.exp 2002/02/21 20:58:25 1.18
> +++ asm-source.exp 2002/03/25 19:33:12
> @@ -41,6 +41,11 @@ if [istarget "*arm-*-*"] then {
> if [istarget "xscale-*-*"] then {
> set asm-arch arm
> }
> +if [istarget "alpha*-*-*"] then {
> + set asm-arch alpha
> + set asm-flags "-gdwarf2 -I${srcdir}/${subdir}
> -I${objdir}/${subdir}"
> +}
> if [istarget "d10v-*-*"] then {
> set asm-arch d10v
> }
>
> Index: configure
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
> retrieving revision 1.8
> diff -u -p -r1.8 configure
> --- configure 2001/12/20 22:12:20 1.8
> +++ configure 2002/03/25 19:34:11
> @@ -637,6 +637,7 @@ archinc=common.inc
> case ${target} in
> *arm-*-*) archinc=arm.inc ;;
> xscale-*-*) archinc=arm.inc ;;
> +alpha*-*-*) archinc=alpha.inc ;;
> d10v-*-*) archinc=d10v.inc ;;
>
>
> Index: configure.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
> retrieving revision 1.8
> diff -u -p -r1.8 configure.in
> --- configure.in 2001/12/20 22:12:20 1.8
> +++ configure.in 2002/03/25 19:34:37
> @@ -17,6 +17,7 @@ archinc=common.inc
> case ${target} in
> *arm-*-*) archinc=arm.inc ;;
> xscale-*-*) archinc=arm.inc ;;
> +alpha*-*-*) archinc=alpha.inc ;;
> d10v-*-*) archinc=d10v.inc ;;
>
> (new file) alpha.inc
> ---------------------
> comment "subroutine prologue"
> .macro gdbasm_enter
> subq $30,32,$30
> stq $26,0($30)
> stq $15,8($30)
> bis $30,$30,$15
> .endm
>
> comment "subroutine epilogue"
> .macro gdbasm_leave
> bis $15,$15,$30
> ldq $26,0($30)
> ldq $15,8($30)
> addq $30,32,$30
> ret $31,($26),1
> .endm
>
> .macro gdbasm_call subr
> bsr $26, \subr
> .endm
>
> .macro gdbasm_several_nops
> nop
> nop
> nop
> nop
> .endm
>
> comment "exit (0)"
> .macro gdbasm_exit0
> halt
> .endm
>
> comment "crt0 startup"
> .macro gdbasm_startup
> clr $fp
> .endm
>
> comment "Declare a data variable"
> .macro gdbasm_datavar name value
> .data
> \name:
> .long \value
> .endm
>
> Thanks
> Priya
>
> > -----Original Message-----
> > From: Andrew Cagney [mailto:ac131313@cygnus.com]
> > Sent: Saturday, March 23, 2002 2:19 PM
> > To: Kuppuswamy, Priyadarshini
> > Cc: gdb-patches@sources.redhat.com; clp@iol.unh.edu
> > Subject: Re: [PATCH] Add alpha target to asm-source.exp test
> >
> >
> > Hello,
> >
> > Can I suggest re-submitting your alpha patch, your assignment
> > has come
> > in so it can now be properly reviewed by the testsuite maintainer.
> >
> > Andrew
> >
> >
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2002-03-29 20:39 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-02-07 14:16 [PATCH] Add alpha target to asm-source.exp test Kuppuswamy, Priyadarshini
2002-02-07 14:32 ` Michael Snyder
2002-02-07 14:52 ` Fernando Nasser
2002-02-07 15:18 ` George France
2002-02-07 19:30 ` Daniel Jacobowitz
2002-02-08 10:44 ` Michael Snyder
2002-02-11 11:58 ` George France
2002-03-23 11:18 ` Andrew Cagney
2002-03-23 11:18 ` Andrew Cagney
2002-03-25 11:47 Kuppuswamy, Priyadarshini
2002-03-28 12:58 ` Fernando Nasser
2002-03-29 12:39 Kuppuswamy, Priyadarshini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox