From: Andrew Cagney <ac131313@cygnus.com>
To: thorpej@wasabisystems.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Use MAXPATHLEN, fix sunos build problem
Date: Sat, 19 Jan 2002 18:56:00 -0000 [thread overview]
Message-ID: <3C4A31EB.5080504@cygnus.com> (raw)
In-Reply-To: <20020119173843.N8364@dr-evil.shagadelic.org>
> On Sat, Jan 19, 2002 at 07:43:35PM -0500, Andrew Cagney wrote:
>
> > 2002-01-19 Andrew Cagney <ac131313@redhat.com>
>> > * utils.c: Include <sys/param.h> for MAXPATHLEN.
> > (gdb_realpath): Use MAXPATHLEN when PATH_MAX is not defined.
>
> Seems like you really want PATH_MAX to be an autoconf test, and if
> not, then test for MAXPATHLEN in <sys/param.h> and define PATH_MAX
> in terms of MAXPATHLEN.
>
> Basically, <machine/param.h> is by no means a standardized header, and
> pulling it in causes all sorts of namespace pollution, so you wanna
> use it only if you have to.
Did you mean machine/param.h or sys/param.h? sys/param.h is currently
pulled in all over the place un-guarded (which is probably a bad thing).
Andrew
next prev parent reply other threads:[~2002-01-20 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-19 16:43 Andrew Cagney
2002-01-19 17:39 ` Jason R Thorpe
2002-01-19 18:56 ` Andrew Cagney [this message]
2002-01-19 19:29 ` Jason R Thorpe
2002-02-10 8:39 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C4A31EB.5080504@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=thorpej@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox