From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29104 invoked by alias); 20 Jan 2002 02:56:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29070 invoked from network); 20 Jan 2002 02:56:51 -0000 Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213) by sources.redhat.com with SMTP; 20 Jan 2002 02:56:51 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 333BD3F09; Sat, 19 Jan 2002 21:56:44 -0500 (EST) Message-ID: <3C4A31EB.5080504@cygnus.com> Date: Sat, 19 Jan 2002 18:56:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103 X-Accept-Language: en-us MIME-Version: 1.0 To: thorpej@wasabisystems.com Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Use MAXPATHLEN, fix sunos build problem References: <3C4A12B7.3040502@cygnus.com> <20020119173843.N8364@dr-evil.shagadelic.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00554.txt.bz2 > On Sat, Jan 19, 2002 at 07:43:35PM -0500, Andrew Cagney wrote: > > > 2002-01-19 Andrew Cagney >> > * utils.c: Include for MAXPATHLEN. > > (gdb_realpath): Use MAXPATHLEN when PATH_MAX is not defined. > > Seems like you really want PATH_MAX to be an autoconf test, and if > not, then test for MAXPATHLEN in and define PATH_MAX > in terms of MAXPATHLEN. > > Basically, is by no means a standardized header, and > pulling it in causes all sorts of namespace pollution, so you wanna > use it only if you have to. Did you mean machine/param.h or sys/param.h? sys/param.h is currently pulled in all over the place un-guarded (which is probably a bad thing). Andrew