From: Andrew Cagney <ac131313@cygnus.com>
To: thorpej@wasabisystems.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Support for alpha*-*-netbsd*
Date: Fri, 18 Jan 2002 08:32:00 -0000 [thread overview]
Message-ID: <3C484E12.5000102@cygnus.com> (raw)
In-Reply-To: <20020118081514.A28259@dr-evil.shagadelic.org>
> > alphabsd-nat.c: The changes are approved (separatly) but please change
> > the macro GETREGS_SUPPLIES into a function.
>
> Hm. It's a macro in a lot of other files, as well. It's not intended to
> be used outside that source module ... should all the other macro versions
> of it be functions, too?
Sigh, yes, you're the innocent party in all this. It is why certain
coding pratices are being agressivly eliminated from GDB - so that
people don't innocently copy them.
Those same macros in the other files really should be changed to static
functions (I'm not exactly going to run out and hold my breath waiting
for it to happen though :-).
http://sources.redhat.com/gdb/onlinedocs/gdbint_13.html#SEC107
Andrew
next prev parent reply other threads:[~2002-01-18 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-17 22:48 Jason R Thorpe
2002-01-18 0:15 ` Eli Zaretskii
2002-01-18 6:36 ` Andrew Cagney
2002-01-18 8:15 ` Jason R Thorpe
2002-01-18 8:32 ` Andrew Cagney [this message]
2002-01-18 9:16 ` Andrew Cagney
2002-01-18 9:28 ` Jason R Thorpe
2002-01-18 9:49 ` Andrew Cagney
2002-01-18 9:51 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C484E12.5000102@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=thorpej@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox