From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2109 invoked by alias); 18 Jan 2002 16:32:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2077 invoked from network); 18 Jan 2002 16:32:19 -0000 Received: from unknown (HELO localhost.cygnus.com) (216.138.202.10) by sources.redhat.com with SMTP; 18 Jan 2002 16:32:19 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 39C1A3D29; Fri, 18 Jan 2002 11:32:19 -0500 (EST) Message-ID: <3C484E12.5000102@cygnus.com> Date: Fri, 18 Jan 2002 08:32:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103 X-Accept-Language: en-us MIME-Version: 1.0 To: thorpej@wasabisystems.com Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Support for alpha*-*-netbsd* References: <20020117224847.P15405@dr-evil.shagadelic.org> <3C4832FB.9060708@cygnus.com> <20020118081514.A28259@dr-evil.shagadelic.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00510.txt.bz2 > > alphabsd-nat.c: The changes are approved (separatly) but please change > > the macro GETREGS_SUPPLIES into a function. > > Hm. It's a macro in a lot of other files, as well. It's not intended to > be used outside that source module ... should all the other macro versions > of it be functions, too? Sigh, yes, you're the innocent party in all this. It is why certain coding pratices are being agressivly eliminated from GDB - so that people don't innocently copy them. Those same macros in the other files really should be changed to static functions (I'm not exactly going to run out and hold my breath waiting for it to happen though :-). http://sources.redhat.com/gdb/onlinedocs/gdbint_13.html#SEC107 Andrew