* Disable gdb.threads-hp
@ 2001-12-20 15:48 law
2001-12-23 1:44 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: law @ 2001-12-20 15:48 UTC (permalink / raw)
To: gdb-patches
As they stand, these tests are horribly broken. Someone may want to
resurrect them one day. For now, I'm disabling them. Per Fernando's
early email, I'm going to go ahead and check-in this change.
* gdb.hp/gdb.threads-hp/usrthbasic.exp: Disable completely.
* gdb.hp/gdb.threads-hp/usrthcore.exp: Disable completely.
* gdb.hp/gdb.threads-hp/usrthfork.exp: Disable completely.
Index: gdb.hp/gdb.threads-hp/usrthbasic.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.threads-hp/usrthbasic.exp
,v
retrieving revision 1.1.350.1
diff -c -3 -p -r1.1.350.1 usrthbasic.exp
*** usrthbasic.exp 2001/12/19 20:52:17 1.1.350.1
--- usrthbasic.exp 2001/12/20 23:43:27
***************
*** 22,27 ****
--- 22,30 ----
#
#log_user 1
+ verbose "HP's thread tests are broken beyond repair right now."
+ return 0
+
if $tracelevel {
strace $tracelevel
}
Index: gdb.hp/gdb.threads-hp/usrthcore.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.threads-hp/usrthcore.exp,
v
retrieving revision 1.1.350.1
diff -c -3 -p -r1.1.350.1 usrthcore.exp
*** usrthcore.exp 2001/12/19 20:52:17 1.1.350.1
--- usrthcore.exp 2001/12/20 23:43:27
***************
*** 22,27 ****
--- 22,30 ----
#
#log_user 1
+ verbose "HP's thread tests are broken beyond repair right now."
+ return 0
+
if $tracelevel {
strace $tracelevel
}
Index: gdb.hp/gdb.threads-hp/usrthfork.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.threads-hp/usrthfork.exp,
v
retrieving revision 1.1.350.1
diff -c -3 -p -r1.1.350.1 usrthfork.exp
*** usrthfork.exp 2001/12/19 20:52:17 1.1.350.1
--- usrthfork.exp 2001/12/20 23:43:27
***************
*** 18,23 ****
--- 18,26 ----
# Please email any bugs, comments, and/or additions to this file to:
# bug-gdb@prep.ai.mit.edu
+ verbose "HP's thread tests are broken beyond repair right now."
+ return 0
+
if $tracelevel {
strace $tracelevel
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Disable gdb.threads-hp
2001-12-20 15:48 Disable gdb.threads-hp law
@ 2001-12-23 1:44 ` Andrew Cagney
2001-12-27 14:02 ` law
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2001-12-23 1:44 UTC (permalink / raw)
To: law; +Cc: gdb-patches
> As they stand, these tests are horribly broken. Someone may want to
> resurrect them one day. For now, I'm disabling them. Per Fernando's
> early email, I'm going to go ahead and check-in this change.
>
> * gdb.hp/gdb.threads-hp/usrthbasic.exp: Disable completely.
> * gdb.hp/gdb.threads-hp/usrthcore.exp: Disable completely.
> * gdb.hp/gdb.threads-hp/usrthfork.exp: Disable completely.
Jeff,
A GDB convention is to add an ``OBSOLETE'' prefix to code like this -
that way people using search scripts can ignore those lines. In
addition, GDB takes a pretty ruthless aproach to such code and deletes
it after the next release.
Since this is tcl, I suspect the prefix should be:
# OBSOLETE
can I suggest also adding that.
enjoy,
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Disable gdb.threads-hp
2001-12-23 1:44 ` Andrew Cagney
@ 2001-12-27 14:02 ` law
2002-01-11 10:19 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: law @ 2001-12-27 14:02 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
> A GDB convention is to add an ``OBSOLETE'' prefix to code like this -
> that way people using search scripts can ignore those lines. In
> addition, GDB takes a pretty ruthless aproach to such code and deletes
> it after the next release.
>
> Since this is tcl, I suspect the prefix should be:
>
> # OBSOLETE
>
> can I suggest also adding that.
FWIW, GDB has a much saner method for dealing with obsolete stuff than GCC;
hopefully GCC can learn something from how y'all are handling these kinds of
issues.
Presumably you just want an OBSOLETE marker at the top of those test files?
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Disable gdb.threads-hp
2001-12-27 14:02 ` law
@ 2002-01-11 10:19 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2002-01-11 10:19 UTC (permalink / raw)
To: law; +Cc: gdb-patches
> > A GDB convention is to add an ``OBSOLETE'' prefix to code like this -
> > that way people using search scripts can ignore those lines. In
> > addition, GDB takes a pretty ruthless aproach to such code and deletes
> > it after the next release.
> > > Since this is tcl, I suspect the prefix should be:
> > > # OBSOLETE
> > > can I suggest also adding that.
> FWIW, GDB has a much saner method for dealing with obsolete stuff than GCC;
> hopefully GCC can learn something from how y'all are handling these kinds of
> issues.
Are you sure about this now that we've started looking at obsoleting
half the targets? :-)
> Presumably you just want an OBSOLETE marker at the top of those test files?
It is more like this:
# OBSOLETE # usrthbasic.exp -- Expect script to test gdb with user threads
# OBSOLETE # Copyright (C) 1992 Free Software Foundation, Inc.
# OBSOLETE
I'll post a patch.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-01-11 18:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-20 15:48 Disable gdb.threads-hp law
2001-12-23 1:44 ` Andrew Cagney
2001-12-27 14:02 ` law
2002-01-11 10:19 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox