Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: matthew green <mrg@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] include sim/common/sim-fpu.c in PSIM.
Date: Tue, 11 Dec 2001 16:02:00 -0000	[thread overview]
Message-ID: <3C16975E.3040902@cygnus.com> (raw)
In-Reply-To: <21344.1007972305@cygnus.com>

>> hi folks.
>> 
>> 
>> this patch enables the use of sim-fpu.c FP functions inside PSIM.
>> not included are any changes to use these functions, merely the
>> infrastructure work required.  as many macros conflicted with
>> sim-common, i had to rename many psim macros.  the name changes
>> are either of the form s/SIM/PSIM/ or s/^/PSIM_/.
>> 
>> i have verified that both gdb & psim tests work equally with
>> or without this patch.
>> 
>> 
>> OK?
> 
> 
Fine with the theory.   I'd like to be able to use sim-fpu.[hc] from GDB as well so the more sim/common is broken down and simplified the better.  This is hopefully helping.
 
One concern is with the Makefile.in change.  From memory your ment to use $(srcdir)/../..... and $< isn't a good idea either - check Ben Harris's recent changes to gdb's Makefile.in.

BTW, don't forget to chomp out the changes to the generated configure file when posting the patch.

	Andrew




  reply	other threads:[~2001-12-12  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-10  0:20 matthew green
2001-12-11 16:02 ` Andrew Cagney [this message]
2001-12-12 22:15   ` matthew green
2001-12-13 10:53     ` Andrew Cagney
2001-12-13 17:04       ` matthew green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C16975E.3040902@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mrg@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox