From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11249-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 12725 invoked by alias); 12 Dec 2001 00:02:13 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 12668 invoked from network); 12 Dec 2001 00:02:09 -0000
Received: from unknown (HELO localhost.cygnus.com) (205.180.231.71)
  by sources.redhat.com with SMTP; 12 Dec 2001 00:02:09 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.cygnus.com (Postfix) with ESMTP
	id A68AE3E29; Tue, 11 Dec 2001 15:31:42 -0800 (PST)
Message-ID: <3C16975E.3040902@cygnus.com>
Date: Tue, 11 Dec 2001 16:02:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.6) Gecko/20011207
X-Accept-Language: en-us
MIME-Version: 1.0
To: matthew green <mrg@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] include sim/common/sim-fpu.c in PSIM.
References: <21344.1007972305@cygnus.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2001-12/txt/msg00316.txt.bz2

>> hi folks.
>> 
>> 
>> this patch enables the use of sim-fpu.c FP functions inside PSIM.
>> not included are any changes to use these functions, merely the
>> infrastructure work required.  as many macros conflicted with
>> sim-common, i had to rename many psim macros.  the name changes
>> are either of the form s/SIM/PSIM/ or s/^/PSIM_/.
>> 
>> i have verified that both gdb & psim tests work equally with
>> or without this patch.
>> 
>> 
>> OK?
> 
> 
Fine with the theory.   I'd like to be able to use sim-fpu.[hc] from GDB as well so the more sim/common is broken down and simplified the better.  This is hopefully helping.
 
One concern is with the Makefile.in change.  From memory your ment to use $(srcdir)/../..... and $< isn't a good idea either - check Ben Harris's recent changes to gdb's Makefile.in.

BTW, don't forget to chomp out the changes to the generated configure file when posting the patch.

	Andrew