Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* RFA: asm-source.exp: anchor regexp matching entry point symbol name
@ 2001-12-08 11:50 Jim Blandy
  2001-12-10 10:13 ` Michael Snyder
  0 siblings, 1 reply; 3+ messages in thread
From: Jim Blandy @ 2001-12-08 11:50 UTC (permalink / raw)
  To: gdb-patches


2001-12-08  Jim Blandy  <jimb@redhat.com>

	* gdb.asm/asm-source.exp (info symbol): Anchor the pattern
 	matching the entry point symbol's name at the beginning of the
 	line.

Index: gdb/testsuite/gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.12
diff -c -r1.12 asm-source.exp
*** gdb/testsuite/gdb.asm/asm-source.exp	2001/12/07 02:50:02	1.12
--- gdb/testsuite/gdb.asm/asm-source.exp	2001/12/08 19:49:07
***************
*** 122,128 ****
      -re "info symbol 0x$entry_point\[\r\n\]*" {
  	exp_continue
      }
!     -re "(.*) in section .*$gdb_prompt $" {
  	set entry_symbol $expect_out(1,string)
  	pass "info symbol"
      }
--- 122,131 ----
      -re "info symbol 0x$entry_point\[\r\n\]*" {
  	exp_continue
      }
!     -re "^(.*) in section .*$gdb_prompt $" {
!         # It's important to anchor the pattern above at the beginning
!         # of the line.  Without that carat, the (.*) may end up
!         # matching the empty string.
  	set entry_symbol $expect_out(1,string)
  	pass "info symbol"
      }


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RFA: asm-source.exp: anchor regexp matching entry point symbol name
  2001-12-08 11:50 RFA: asm-source.exp: anchor regexp matching entry point symbol name Jim Blandy
@ 2001-12-10 10:13 ` Michael Snyder
  2001-12-10 12:32   ` Jim Blandy
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2001-12-10 10:13 UTC (permalink / raw)
  To: Jim Blandy; +Cc: gdb-patches

Jim Blandy wrote:
> 
> 2001-12-08  Jim Blandy  <jimb@redhat.com>
> 
>         * gdb.asm/asm-source.exp (info symbol): Anchor the pattern
>         matching the entry point symbol's name at the beginning of the
>         line.

Thanks -- that's what I meant to do.  
Please check it in.

> 
> Index: gdb/testsuite/gdb.asm/asm-source.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.12
> diff -c -r1.12 asm-source.exp
> *** gdb/testsuite/gdb.asm/asm-source.exp        2001/12/07 02:50:02     1.12
> --- gdb/testsuite/gdb.asm/asm-source.exp        2001/12/08 19:49:07
> ***************
> *** 122,128 ****
>       -re "info symbol 0x$entry_point\[\r\n\]*" {
>         exp_continue
>       }
> !     -re "(.*) in section .*$gdb_prompt $" {
>         set entry_symbol $expect_out(1,string)
>         pass "info symbol"
>       }
> --- 122,131 ----
>       -re "info symbol 0x$entry_point\[\r\n\]*" {
>         exp_continue
>       }
> !     -re "^(.*) in section .*$gdb_prompt $" {
> !         # It's important to anchor the pattern above at the beginning
> !         # of the line.  Without that carat, the (.*) may end up
> !         # matching the empty string.
>         set entry_symbol $expect_out(1,string)
>         pass "info symbol"
>       }


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RFA: asm-source.exp: anchor regexp matching entry point symbol name
  2001-12-10 10:13 ` Michael Snyder
@ 2001-12-10 12:32   ` Jim Blandy
  0 siblings, 0 replies; 3+ messages in thread
From: Jim Blandy @ 2001-12-10 12:32 UTC (permalink / raw)
  To: Michael Snyder; +Cc: gdb-patches


Committed, thanks.

Michael Snyder <msnyder@cygnus.com> writes:

> 
> Jim Blandy wrote:
> > 
> > 2001-12-08  Jim Blandy  <jimb@redhat.com>
> > 
> >         * gdb.asm/asm-source.exp (info symbol): Anchor the pattern
> >         matching the entry point symbol's name at the beginning of the
> >         line.
> 
> Thanks -- that's what I meant to do.  
> Please check it in.
> 
> > 
> > Index: gdb/testsuite/gdb.asm/asm-source.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> > retrieving revision 1.12
> > diff -c -r1.12 asm-source.exp
> > *** gdb/testsuite/gdb.asm/asm-source.exp        2001/12/07 02:50:02     1.12
> > --- gdb/testsuite/gdb.asm/asm-source.exp        2001/12/08 19:49:07
> > ***************
> > *** 122,128 ****
> >       -re "info symbol 0x$entry_point\[\r\n\]*" {
> >         exp_continue
> >       }
> > !     -re "(.*) in section .*$gdb_prompt $" {
> >         set entry_symbol $expect_out(1,string)
> >         pass "info symbol"
> >       }
> > --- 122,131 ----
> >       -re "info symbol 0x$entry_point\[\r\n\]*" {
> >         exp_continue
> >       }
> > !     -re "^(.*) in section .*$gdb_prompt $" {
> > !         # It's important to anchor the pattern above at the beginning
> > !         # of the line.  Without that carat, the (.*) may end up
> > !         # matching the empty string.
> >         set entry_symbol $expect_out(1,string)
> >         pass "info symbol"
> >       }
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-12-10 20:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-08 11:50 RFA: asm-source.exp: anchor regexp matching entry point symbol name Jim Blandy
2001-12-10 10:13 ` Michael Snyder
2001-12-10 12:32   ` Jim Blandy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox