Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix regexp problem with "operator* etc.
Date: Mon, 03 Dec 2001 11:17:00 -0000	[thread overview]
Message-ID: <3C0BCFF9.3C476F2@cygnus.com> (raw)
In-Reply-To: <200111020929.DAA09585@duracef.shout.net>


I committed this change, without Michael Chastain's worthy suggestion
regarding the size of the alloca.  Will submit that separately.

Michael Elizabeth Chastain wrote:
> 
> cplusfuncs.exp:
>   In my maintainer area.
>   Approved unconditionally.
>   No matter what gdb does, the test script should do the right thing.
> 
> alloca change:
>   Outside my maintainer area.
>   Recommended for rework.
> 
>   I think the size is long enough, but the proof of correctness is
>   too delicate.  There is no space explicitly allocated for the final
>   null, so the alloca is correct only because it occurs in a context
>   where at least one character is being deleted.  This also relies on
>   some character-class tests being the same in this function and
>   in operator_chars.   How about something stupidly correct:
> 
>     alloca (8 + fix + strlen(opname) + 1)
> 
> operator_chars change:
>   Outside my maintainer area.
>   Proofread and tested, works for me.
>   Recommended for approval.
> 
> doc/gdb.texinfo:
>   Outside my maintainer area.
> 
>   Recommend add a sentence or two to "@kindex info functions" about functions
>   like "operator[]" and "operator const char *" and how to get at them with
>   "info func operator\[\]" and "info func operator const char \*".
> 
>   Since there is no way at all to type these names in gdb right now,
>   the code can be fixed before the doc is dixed.
> 
> I did my testing on native i686-pc-linux-gnu with gcc 2.95.3 and gcc 3.0.2.
> 
> Michael C


       reply	other threads:[~2001-12-03 19:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200111020929.DAA09585@duracef.shout.net>
2001-12-03 11:17 ` Michael Snyder [this message]
2001-12-05  5:55   ` Elena Zannoni
2001-12-05 12:13     ` Michael Snyder
2001-12-05 12:39       ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0BCFF9.3C476F2@cygnus.com \
    --to=msnyder@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox