From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11443 invoked by alias); 3 Dec 2001 19:17:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11420 invoked from network); 3 Dec 2001 19:17:15 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 3 Dec 2001 19:17:15 -0000 Received: from cygnus.com (taarna.cygnus.com [205.180.230.102]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA18064 for ; Mon, 3 Dec 2001 11:17:14 -0800 (PST) Message-ID: <3C0BCFF9.3C476F2@cygnus.com> Date: Mon, 03 Dec 2001 11:17:00 -0000 From: Michael Snyder Organization: Red Hat X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.2.16-22 i686) X-Accept-Language: en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix regexp problem with "operator* etc. References: <200111020929.DAA09585@duracef.shout.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00050.txt.bz2 I committed this change, without Michael Chastain's worthy suggestion regarding the size of the alloca. Will submit that separately. Michael Elizabeth Chastain wrote: > > cplusfuncs.exp: > In my maintainer area. > Approved unconditionally. > No matter what gdb does, the test script should do the right thing. > > alloca change: > Outside my maintainer area. > Recommended for rework. > > I think the size is long enough, but the proof of correctness is > too delicate. There is no space explicitly allocated for the final > null, so the alloca is correct only because it occurs in a context > where at least one character is being deleted. This also relies on > some character-class tests being the same in this function and > in operator_chars. How about something stupidly correct: > > alloca (8 + fix + strlen(opname) + 1) > > operator_chars change: > Outside my maintainer area. > Proofread and tested, works for me. > Recommended for approval. > > doc/gdb.texinfo: > Outside my maintainer area. > > Recommend add a sentence or two to "@kindex info functions" about functions > like "operator[]" and "operator const char *" and how to get at them with > "info func operator\[\]" and "info func operator const char \*". > > Since there is no way at all to type these names in gdb right now, > the code can be fixed before the doc is dixed. > > I did my testing on native i686-pc-linux-gnu with gcc 2.95.3 and gcc 3.0.2. > > Michael C