[RFA] Add ix86 target to asm-source.exp test

[RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

This is a minimal port of the asm-source test to the i[3456]86 target.
This runs successfully on a Linux x86 machine, but will probably need
some work to make it run on other ix86 platforms (esp. embedded).

The file "i386.inc" is appended at the end of the patch.

Andrew -- since Fernando is stepping down as testsuite maintainer, 
and since you've tinkered with asm-source, perhaps you could play
the role of second-pair-of-eyes?

Michael

2001-11-20  Michael Snyder  <msnyder@redhat.com>

	* gdb.asm/i386.inc: New file.
	* gdb.asm/asm-source.exp: Recognize ix86 target.
	* gdb.asm/configure.in: Recognize ix86 target.
	* gdb.asm/configure: Regenerate.

Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure,v
retrieving revision 1.1.1.1
diff -c -3 -p -r1.1.1.1 configure
*** configure	1999/04/16 01:34:30	1.1.1.1
--- configure	2001/11/21 01:46:48
*************** test "$host_alias" != "$target_alias" &&
*** 634,639 ****
--- 634,640 ----
  archinc=common.inc
  case ${target} in
  d10v-*-*) archinc=d10v.inc ;;
+ i[3456]86*) archinc=i386.inc ;;
  esac
  
  
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/configure.in,v
retrieving revision 1.1.1.1
diff -c -3 -p -r1.1.1.1 configure.in
*** configure.in	1999/04/16 01:34:30	1.1.1.1
--- configure.in	2001/11/21 01:46:48
*************** dnl In default case we need to link with
*** 16,21 ****
--- 16,22 ----
  archinc=common.inc
  case ${target} in
  d10v-*-*) archinc=d10v.inc ;;
+ i[3456]86*) archinc=i386.inc ;;
  esac
  AC_LINK_FILES($archinc,arch.inc)
  
Index: asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.5
diff -c -3 -p -r1.5 asm-source.exp
*** asm-source.exp	2001/11/10 01:44:43	1.5
--- asm-source.exp	2001/11/21 01:46:48
*************** set asm-flags ""
*** 37,42 ****
--- 37,45 ----
  if [istarget "d10v-*-*"] then {
      set asm-arch d10v
  }
+ if [istarget "i\[3456\]86-*-*"] then {
+     set asm-arch i386
+ }
  if { "${asm-arch}" == "" } {
      gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
  }

	comment "subroutine prologue"
	.macro gdbasm_enter
	push	%ebp
	mov	%esp,%ebp
	.endm

	comment "subroutine epilogue"
	.macro gdbasm_leave
	pop	%ebp
	ret
	.endm

	.macro gdbasm_call subr
	call	\subr
	.endm

	.macro gdbasm_several_nops
	nop
	nop
	nop
	nop
	.endm

	comment "exit (0)"
	.macro gdbasm_exit0
	hlt
	.endm

	comment "crt0 startup"
	.macro gdbasm_startup
	xor	%ebp, %ebp
	.endm

Re: [RFA] Add ix86 target to asm-source.exp test

[Pierre Muller]

At 02:51 21/11/2001 , vous avez écrit:

>This is a minimal port of the asm-source test to the i[3456]86 target.
>This runs successfully on a Linux x86 machine, but will probably need
>some work to make it run on other ix86 platforms (esp. embedded).
>         comment "exit (0)"
>         .macro gdbasm_exit0
>         hlt
>         .endm

   Is it reasonable to include a priviledged instruction
at that point ?
   All depends if this code is possibly executed...


Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: [RFA] Add ix86 target to asm-source.exp test

[Andrew Cagney]

> This is a minimal port of the asm-source test to the i[3456]86 target.
> This runs successfully on a Linux x86 machine, but will probably need
> some work to make it run on other ix86 platforms (esp. embedded).

We desperatly need to get people to fill out the gdb.asm directory (and 
the only way to write this file is to test it) so I think adding this 
should be considered pretty obvious.  I'd say, give it a day.

Andrew

> Michael
> 
> 2001-11-20  Michael Snyder  <msnyder@redhat.com>
> 
> * gdb.asm/i386.inc: New file.
> 	* gdb.asm/asm-source.exp: Recognize ix86 target.
> 	* gdb.asm/configure.in: Recognize ix86 target.
> 	* gdb.asm/configure: Regenerate.
> 

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

Pierre Muller wrote:
> 
> At 02:51 21/11/2001 , vous avez écrit:
> 
> >This is a minimal port of the asm-source test to the i[3456]86 target.
> >This runs successfully on a Linux x86 machine, but will probably need
> >some work to make it run on other ix86 platforms (esp. embedded).
> >         comment "exit (0)"
> >         .macro gdbasm_exit0
> >         hlt
> >         .endm
> 
>    Is it reasonable to include a priviledged instruction
> at that point ?
>    All depends if this code is possibly executed...

The code is not intended to be executed, I just put the
halt there to make sure that it would terminate if it 
ran away.  And in fact it does terminate, on Linux, with
a SEGV signal.

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

Andrew Cagney wrote:
> 
> > This is a minimal port of the asm-source test to the i[3456]86 target.
> > This runs successfully on a Linux x86 machine, but will probably need
> > some work to make it run on other ix86 platforms (esp. embedded).
> 
> We desperatly need to get people to fill out the gdb.asm directory (and
> the only way to write this file is to test it) so I think adding this
> should be considered pretty obvious.  I'd say, give it a day.

Committed.

> > 2001-11-20  Michael Snyder  <msnyder@redhat.com>
> >
> > * gdb.asm/i386.inc: New file.
> >       * gdb.asm/asm-source.exp: Recognize ix86 target.
> >       * gdb.asm/configure.in: Recognize ix86 target.
> >       * gdb.asm/configure: Regenerate.
> >

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

"Kuppuswamy, Priyadarshini" wrote:
> 
> In asm-source.exp  file, initially it checks for the assembly source
> file based on the target(d10v.inc, sparc.inc or intel[345]86.inc]. I
> notice that the assembly file has been implemented for sparc, intel.  I
> ran the tests on alpha and I see that the assembly source file for alpha
> has not been implemented and hence it's giving  the following errors. So
> all the test cases in that file are failing.
> 
[snipped error messages]

> WARNING: Testcase compile failed, so all tests in this file will
> automatically fail.
> 
> Or am I missing something here??

No, you're not.  The test has to be individually implemented for
each target architecture, and no one has contributed an "alpha.inc"
file yet.  Would you like to volunteer?   ;-)

Michael

Re: [RFA] Add ix86 target to asm-source.exp test

[Kuppuswamy, Priyadarshini]

In asm-source.exp  file, initially it checks for the assembly source
file based on the target(d10v.inc, sparc.inc or intel[345]86.inc]. I
notice that the assembly file has been implemented for sparc, intel.  I
ran the tests on alpha and I see that the assembly source file for alpha
has not been implemented and hence it's giving  the following errors. So
all the test cases in that file are failing.

Running
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asm-source.e
xp ...
WARNING: Assembly source test -- not implemented for this target.

Executing on host: as
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s
-gstabs -I/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm
-I/mnt/u2/toolchain/buildsys/build/alpha7/basic-gcc_3.0.2/native/src-gdb
/gdb/testsuite/gdb.asm -o asmsrc1.o    (timeout = 300)
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:
Assembler messages:^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:14
: Error: unknown opcode `gdbasm_startup'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:15
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:16
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:25
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:29
: Error: unknown opcode `gdbasm_several_nops'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:33
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:37
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:43
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:44
: Error: unknown opcode `gdbasm_leave'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:48
: Error: unknown opcode `gdbasm_exit'^M
assembler exited with status 1
assembler output is:
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:
Assembler messages:^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:14
: Error: unknown opcode `gdbasm_startup'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:15
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:16
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:25
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:29
: Error: unknown opcode `gdbasm_several_nops'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:33
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:37
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:43
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:44
: Error: unknown opcode `gdbasm_leave'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:48
: Error: unknown opcode `gdbasm_exit'^M

WARNING: Testcase compile failed, so all tests in this file will
automatically fail.

Or am I missing something here??

Thanks
Priya

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

Michael Elizabeth Chastain wrote:
> 
> I ran the new asm-source.exp test for x86 targets and it is not working for me.

Michael, this is not due to anything about the test itself, but rather
to a regression introduced by this change:

	symtab.c (find_pc_sect_line): If we can't find the function
	containing PC, we certainly won't have line number information for
	that location, so return zero immediately.

As you can imagine, the premise for this change is incorrect
for an assembly language file assembled with line info.

If you back out this change, I think the test will work for you.

				Michael

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

"Kuppuswamy, Priyadarshini" wrote:
> 
> In asm-source.exp  file, initially it checks for the assembly source
> file based on the target(d10v.inc, sparc.inc or intel[345]86.inc]. I
> notice that the assembly file has been implemented for sparc, intel.  I
> ran the tests on alpha and I see that the assembly source file for alpha
> has not been implemented and hence it's giving  the following errors. So
> all the test cases in that file are failing.
> 
[snipped error messages]

> WARNING: Testcase compile failed, so all tests in this file will
> automatically fail.
> 
> Or am I missing something here??

No, you're not.  The test has to be individually implemented for
each target architecture, and no one has contributed an "alpha.inc"
file yet.  Would you like to volunteer?   ;-)

Michael

Re: [RFA] Add ix86 target to asm-source.exp test

[Kuppuswamy, Priyadarshini]

In asm-source.exp  file, initially it checks for the assembly source
file based on the target(d10v.inc, sparc.inc or intel[345]86.inc]. I
notice that the assembly file has been implemented for sparc, intel.  I
ran the tests on alpha and I see that the assembly source file for alpha
has not been implemented and hence it's giving  the following errors. So
all the test cases in that file are failing.

Running
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asm-source.e
xp ...
WARNING: Assembly source test -- not implemented for this target.

Executing on host: as
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s
-gstabs -I/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm
-I/mnt/u2/toolchain/buildsys/build/alpha7/basic-gcc_3.0.2/native/src-gdb
/gdb/testsuite/gdb.asm -o asmsrc1.o    (timeout = 300)
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:
Assembler messages:^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:14
: Error: unknown opcode `gdbasm_startup'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:15
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:16
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:25
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:29
: Error: unknown opcode `gdbasm_several_nops'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:33
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:37
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:43
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:44
: Error: unknown opcode `gdbasm_leave'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:48
: Error: unknown opcode `gdbasm_exit'^M
assembler exited with status 1
assembler output is:
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:
Assembler messages:^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:14
: Error: unknown opcode `gdbasm_startup'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:15
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:16
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:25
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:29
: Error: unknown opcode `gdbasm_several_nops'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:33
: Error: unknown opcode `gdbasm_call'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:37
: Error: unknown opcode `gdbasm_exit'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:43
: Error: unknown opcode `gdbasm_enter'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:44
: Error: unknown opcode `gdbasm_leave'^M
/mnt/u2/toolchain/buildsys/source/src/gdb/testsuite/gdb.asm/asmsrc1.s:48
: Error: unknown opcode `gdbasm_exit'^M

WARNING: Testcase compile failed, so all tests in this file will
automatically fail.

Or am I missing something here??

Thanks
Priya

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Elizabeth Chastain]

So the test was actually doing its job and pointing to a bug in gdb.
Nice!

I updated symtab.c to the current version, 1.49, where the incorrect
change has been reverted.  The results are a perfect 10 PASS, 0 FAIL
with both binutils-2.11.2 and binutils-HEAD.  More nice!

I'm a happy tester,

Michael C

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Snyder]

Michael Elizabeth Chastain wrote:
> 
> I ran the new asm-source.exp test for x86 targets and it is not working for me.

Michael, this is not due to anything about the test itself, but rather
to a regression introduced by this change:

	symtab.c (find_pc_sect_line): If we can't find the function
	containing PC, we certainly won't have line number information for
	that location, so return zero immediately.

As you can imagine, the premise for this change is incorrect
for an assembly language file assembled with line info.

If you back out this change, I think the test will work for you.

				Michael

Re: [RFA] Add ix86 target to asm-source.exp test

[Michael Elizabeth Chastain]

I ran the new asm-source.exp test for x86 targets and it is not working for me.

My environment: native i686-pc-linux-gnu, red hat linux 7.1, cvs gdb,
various versions of gcc, cvs binutils, dejagnu 1.4.2.

I tried binutils 2.11.2 and /bin/as + /bin/ld as well with no joy.

Here are the excerpts:

  http://www.shout.net/~mec/sunday/2001-11-24/log-asm-source/gcc-2.95.3-excerpt.txt
  http://www.shout.net/~mec/sunday/2001-11-24/log-asm-source/gcc-3.0.2-excerpt.txt
  http://www.shout.net/~mec/sunday/2001-11-24/log-asm-source/gcc-HEAD-excerpt.txt
  http://www.shout.net/~mec/sunday/2001-11-24/log-asm-source/gcc-gcc-3_0-branch-excerpt.txt

Basically, the test fails on the first "f" command, and then
derails on the "s" command in main.

It feels like an environmental dependency, like something is missing or
wrong in my test harness.  If you have all PASSes for this test, can
you post some excerpts from your gdb.log, and tell me what your PATH
is set to?

Michael C