[RFA] patch for mips gdb build failure with latest gcc

[RFA] patch for mips gdb build failure with latest gcc

[Fred Fish]

Gdb for mips does not currently build with the latest gcc.  The error
message is:

  In file included from support.c:26:
  sim-main.h:370: unnamed fields of type other than struct or union are not allowed

The problem is an enum declaration inside a struct declaration, which
is apparently now illegal.  This patch fixes it.


  2001-11-17  Fred Fish  <fnf@redhat.com>

	* sim-main.h (float_operation): Move enum declaration outside
	of _sim_cpu struct declaration.

Index: sim-main.h
===================================================================
RCS file: /cvs/src/src/sim/mips/sim-main.h,v
retrieving revision 1.6
diff -u -p -r1.6 sim-main.h
--- sim-main.h	2001/04/12 14:53:20	1.6
+++ sim-main.h	2001/11/18 04:16:54
@@ -297,6 +297,13 @@ do {									\
 } while (0)
 
 
+enum float_operation
+  {
+    FLOP_ADD,    FLOP_SUB,    FLOP_MUL,    FLOP_MADD,
+    FLOP_MSUB,   FLOP_MAX=10, FLOP_MIN,    FLOP_ABS,
+    FLOP_ITOF0=14, FLOP_FTOI0=18, FLOP_NEG=23
+  };
+
 
 struct _sim_cpu {
 
@@ -361,13 +368,6 @@ struct _sim_cpu {
 
 #endif
 
-
-enum float_operation
-  {
-    FLOP_ADD,    FLOP_SUB,    FLOP_MUL,    FLOP_MADD,
-    FLOP_MSUB,   FLOP_MAX=10, FLOP_MIN,    FLOP_ABS,
-    FLOP_ITOF0=14, FLOP_FTOI0=18, FLOP_NEG=23
-  };
 
 /* To keep this default simulator simple, and fast, we use a direct
    vector of registers. The internal simulator engine then uses

Re: [RFA] patch for mips gdb build failure with latest gcc

[Andrew Cagney]

> Gdb for mips does not currently build with the latest gcc.  The error
> message is:
> 
>   In file included from support.c:26:
>   sim-main.h:370: unnamed fields of type other than struct or union are not allowed
> 
> The problem is an enum declaration inside a struct declaration, which
> is apparently now illegal.  This patch fixes it.
> 
> 
>   2001-11-17  Fred Fish  <fnf@redhat.com>
> 
> * sim-main.h (float_operation): Move enum declaration outside
> 	of _sim_cpu struct declaration.
> 

Little choice on this one :-)
yes, 'n' thanks.

Andrew

Re: [RFA] patch for mips gdb build failure with latest gcc

[Daniel Jacobowitz]

On Sat, Nov 17, 2001 at 09:17:55PM -0700, Fred Fish wrote:
> Gdb for mips does not currently build with the latest gcc.  The error
> message is:
> 
>   In file included from support.c:26:
>   sim-main.h:370: unnamed fields of type other than struct or union are not allowed
> 
> The problem is an enum declaration inside a struct declaration, which
> is apparently now illegal.  This patch fixes it.
> 
> 
>   2001-11-17  Fred Fish  <fnf@redhat.com>
> 
> 	* sim-main.h (float_operation): Move enum declaration outside
> 	of _sim_cpu struct declaration.

For the record, I'm pretty sure this is a bug in GCC, and I think it
may have been fixed on the trunk.  How recent is your "latest" GCC?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] patch for mips gdb build failure with latest gcc

[Fred Fish]

> may have been fixed on the trunk.  How recent is your "latest" GCC?

About an hour before filing the gdb bug report, straight from the head
revision of the gcc repository.  I first noticed this problem probably
a month or two ago.

-Fred