Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>,
	Mark Kettenis <kettenis@science.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFA]: Fix i386-linux-nat.c fill_gregset()
Date: Wed, 07 Nov 2001 08:19:00 -0000	[thread overview]
Message-ID: <3BF6A8B2.3040102@cygnus.com> (raw)
In-Reply-To: <1011117101740.ZM5510@ocotillo.lan>


> Okay to commit?
> 
> 	* i386-linux-nat.c (fill_gregset): Don't invoke read_register_gen()
> 	when fetching ORIG_EAX.
> 
> Index: i386-linux-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-linux-nat.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 i386-linux-nat.c
> --- i386-linux-nat.c	2001/11/04 14:30:42	1.29
> +++ i386-linux-nat.c	2001/11/17 09:14:41
> @@ -325,7 +325,8 @@ fill_gregset (elf_gregset_t *gregsetp, i
>        *(regp + regmap[i]) = *(elf_greg_t *) &registers[REGISTER_BYTE (i)];
>  
>    if (regno == -1 || regno == I386_LINUX_ORIG_EAX_REGNUM)
> -    read_register_gen (I386_LINUX_ORIG_EAX_REGNUM, (char *) (regp + ORIG_EAX));
> +    *(regp + regmap[ORIG_EAX]) =
> +      *(elf_greg_t *) &registers[REGISTER_BYTE (I386_LINUX_ORIG_EAX_REGNUM)];
>  }
>  
>  #ifdef HAVE_PTRACE_GETREGS

FYI,

Using registers[] is wrong.  The code should be using regcache_collect().

Andrew



  parent reply	other threads:[~2001-11-17 18:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-07  8:10 Kevin Buettner
2001-11-07  8:14 ` Mark Kettenis
2001-11-07  8:19 ` Andrew Cagney [this message]
2001-11-07  8:30 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BF6A8B2.3040102@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@science.uva.nl \
    --cc=kevinb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox