From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10609-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 25965 invoked by alias); 17 Nov 2001 18:47:27 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25944 invoked from network); 17 Nov 2001 18:47:26 -0000
Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213)
  by sourceware.cygnus.com with SMTP; 17 Nov 2001 18:47:26 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.cygnus.com (Postfix) with ESMTP
	id 9D7CC3D8B; Sat, 17 Nov 2001 13:13:06 -0500 (EST)
Message-ID: <3BF6A8B2.3040102@cygnus.com>
Date: Wed, 07 Nov 2001 08:19:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.3) Gecko/20011020
X-Accept-Language: en-us
MIME-Version: 1.0
To: Kevin Buettner <kevinb@cygnus.com>,
	Mark Kettenis <kettenis@science.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFA]: Fix i386-linux-nat.c fill_gregset()
References: <1011117101740.ZM5510@ocotillo.lan>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2001-11/txt/msg00105.txt.bz2


> Okay to commit?
> 
> 	* i386-linux-nat.c (fill_gregset): Don't invoke read_register_gen()
> 	when fetching ORIG_EAX.
> 
> Index: i386-linux-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-linux-nat.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 i386-linux-nat.c
> --- i386-linux-nat.c	2001/11/04 14:30:42	1.29
> +++ i386-linux-nat.c	2001/11/17 09:14:41
> @@ -325,7 +325,8 @@ fill_gregset (elf_gregset_t *gregsetp, i
>        *(regp + regmap[i]) = *(elf_greg_t *) &registers[REGISTER_BYTE (i)];
>  
>    if (regno == -1 || regno == I386_LINUX_ORIG_EAX_REGNUM)
> -    read_register_gen (I386_LINUX_ORIG_EAX_REGNUM, (char *) (regp + ORIG_EAX));
> +    *(regp + regmap[ORIG_EAX]) =
> +      *(elf_greg_t *) &registers[REGISTER_BYTE (I386_LINUX_ORIG_EAX_REGNUM)];
>  }
>  
>  #ifdef HAVE_PTRACE_GETREGS

FYI,

Using registers[] is wrong.  The code should be using regcache_collect().

Andrew