From: Andrew Cagney <ac131313@cygnus.com>
To: Ben Harris <bjh21@cam.ac.uk>
Cc: gdb-patches@sources.redhat.com
Subject: Re: sim/arm/Makefile.in fix for non-GNU make
Date: Tue, 06 Nov 2001 20:26:00 -0000 [thread overview]
Message-ID: <3BF43C46.6090005@cygnus.com> (raw)
In-Reply-To: <Pine.SOL.4.33.0111151550070.27674-100000@draco.cus.cam.ac.uk>
> [ Now with a ChangeLog entry ]
In the wrong place :-)
> sim/arm/Makefile.in currently uses $< in a non-implicit rule. This
> doesn't work with non-GNU makes (at least NetBSD's one) since $< isn't set
> for non-implicit rules. This patch fixes the problem:
Yes, thanks, it can go in. If you find more of these the I think they
can be considered obvious.
Can you also, separatly, add yourself to the MAINTAINERS file as an
``obvious fix'' (ie still post the change).
enjoy,
Andrew
> Index: Makefile.in
> ===================================================================
> RCS file: /cvsroot/gnusrc/gnu/dist/toolchain/sim/arm/Makefile.in,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 Makefile.in
> --- Makefile.in 2000/07/26 00:34:28 1.1.1.1
> +++ Makefile.in 2001/11/15 14:57:19
> @@ -31,10 +31,10 @@
> armcopro.o: armcopro.c armdefs.h
>
> armemu26.o: armemu.c armdefs.h armemu.h
> - $(CC) -c $< -o armemu26.o $(ALL_CFLAGS)
> + $(CC) -c $(srcdir)/armemu.c -o armemu26.o $(ALL_CFLAGS)
>
> armemu32.o: armemu.c armdefs.h armemu.h
> - $(CC) -c $< -o armemu32.o -DMODE32 $(ALL_CFLAGS)
> + $(CC) -c $(srcdir)/armemu.c -o armemu32.o -DMODE32 $(ALL_CFLAGS)
>
> arminit.o: arminit.c armdefs.h armemu.h
>
>
> ChangeLog entry (suspiciously similar to one from 1997):
>
> 2001-11-15 Ben Harris <bjh21@netbsd.org>
>
> * Makefile.in (armemu32.o): Replace $< with autoconf recommended
> $(srcdir)/....
> (armemu26.o): Ditto.
>
>
next prev parent reply other threads:[~2001-11-15 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-06 10:04 Ben Harris
2001-11-06 20:26 ` Andrew Cagney [this message]
2001-11-06 22:11 ` Adding me to the MAINTAINERS file Ben Harris
-- strict thread matches above, loose matches on Subject: below --
2001-11-06 10:30 sim/arm/Makefile.in fix for non-GNU make Michael Elizabeth Chastain
2001-11-06 9:03 Ben Harris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF43C46.6090005@cygnus.com \
--to=ac131313@cygnus.com \
--cc=bjh21@cam.ac.uk \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox