From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10598-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 27024 invoked by alias); 15 Nov 2001 22:06:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 27003 invoked from network); 15 Nov 2001 22:06:00 -0000
Received: from unknown (HELO localhost.cygnus.com) (216.138.202.10)
  by sourceware.cygnus.com with SMTP; 15 Nov 2001 22:06:00 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.cygnus.com (Postfix) with ESMTP
	id 7DE193CF6; Thu, 15 Nov 2001 17:05:59 -0500 (EST)
Message-ID: <3BF43C46.6090005@cygnus.com>
Date: Tue, 06 Nov 2001 20:26:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.3) Gecko/20011020
X-Accept-Language: en-us
MIME-Version: 1.0
To: Ben Harris <bjh21@cam.ac.uk>
Cc: gdb-patches@sources.redhat.com
Subject: Re: sim/arm/Makefile.in fix for non-GNU make
References: <Pine.SOL.4.33.0111151550070.27674-100000@draco.cus.cam.ac.uk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2001-11/txt/msg00094.txt.bz2

> [ Now with a ChangeLog entry ]

In the wrong place :-)

> sim/arm/Makefile.in currently uses $< in a non-implicit rule.  This
> doesn't work with non-GNU makes (at least NetBSD's one) since $< isn't set
> for non-implicit rules.  This patch fixes the problem:

Yes, thanks, it can go in.  If you find more of these the I think they 
can be considered obvious.

Can you also, separatly, add yourself to the MAINTAINERS file as an 
``obvious fix'' (ie still post the change).

enjoy,
Andrew


> Index: Makefile.in
> ===================================================================
> RCS file: /cvsroot/gnusrc/gnu/dist/toolchain/sim/arm/Makefile.in,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 Makefile.in
> --- Makefile.in	2000/07/26 00:34:28	1.1.1.1
> +++ Makefile.in	2001/11/15 14:57:19
> @@ -31,10 +31,10 @@
>  armcopro.o: armcopro.c armdefs.h
> 
>  armemu26.o: armemu.c armdefs.h armemu.h
> -	$(CC) -c $< -o armemu26.o $(ALL_CFLAGS)
> +	$(CC) -c $(srcdir)/armemu.c -o armemu26.o $(ALL_CFLAGS)
> 
>  armemu32.o: armemu.c armdefs.h armemu.h
> -	$(CC) -c $< -o armemu32.o -DMODE32 $(ALL_CFLAGS)
> +	$(CC) -c $(srcdir)/armemu.c -o armemu32.o -DMODE32 $(ALL_CFLAGS)
> 
>  arminit.o: arminit.c armdefs.h armemu.h
> 
> 
> ChangeLog entry (suspiciously similar to one from 1997):
> 
> 2001-11-15  Ben Harris  <bjh21@netbsd.org>
> 
> * Makefile.in (armemu32.o): Replace $< with autoconf recommended
>         $(srcdir)/....
>         (armemu26.o): Ditto.
> 
>