From: Andrew Cagney <ac131313@cygnus.com>
To: Jason Molenda <jmolenda@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fear and loathing in lookup_block_symbol
Date: Fri, 14 Sep 2001 07:40:00 -0000 [thread overview]
Message-ID: <3BA216BC.7080706@cygnus.com> (raw)
In-Reply-To: <B849B437-A2F6-11D5-B65F-000393540DDC@apple.com>
> We can't copy the old code's style exactly. SYMBOL_MATCHES_NAME calls strcmp_iw() on the demangled names (to ignore whitespace), but strcmp_iw is poorly named; it doesn't give you a less-than greater-than return value like strcmp(). It'd be better termed streq_iw() or something unlike strcmp(). But we can make vast improvements without digging into this problem by changing the code to something like:
I'd consider a change to fix strcmp_iw() semantics so that it more
correctlu resembles strcmp(), to be an obvious fix.
as for streq(), we're trying to kill off those STREQ() macro's so this
could confuse things :-)
andrew
prev parent reply other threads:[~2001-09-14 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-06 11:41 Jason Molenda
2001-09-06 11:44 ` Jason Molenda
2001-09-07 1:00 ` Jason Molenda
2001-09-07 1:02 ` Jason Molenda
2001-09-07 1:04 ` Jason Molenda
2001-09-14 7:24 ` Andrew Cagney
2001-09-14 7:40 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BA216BC.7080706@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jmolenda@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox