From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Jason Molenda Cc: gdb-patches@sources.redhat.com Subject: Re: Fear and loathing in lookup_block_symbol Date: Fri, 14 Sep 2001 07:40:00 -0000 Message-id: <3BA216BC.7080706@cygnus.com> References: X-SW-Source: 2001-09/msg00178.html > We can't copy the old code's style exactly. SYMBOL_MATCHES_NAME calls strcmp_iw() on the demangled names (to ignore whitespace), but strcmp_iw is poorly named; it doesn't give you a less-than greater-than return value like strcmp(). It'd be better termed streq_iw() or something unlike strcmp(). But we can make vast improvements without digging into this problem by changing the code to something like: I'd consider a change to fix strcmp_iw() semantics so that it more correctlu resembles strcmp(), to be an obvious fix. as for streq(), we're trying to kill off those STREQ() macro's so this could confuse things :-) andrew