Re: RFA: "show user" output

[Fernando Nasser <fnasser@redhat.com>]

Jackie Smith Cashion wrote:
> 
> I recently noticed that the "show user" output is messed up. The "if",
> "else", "while", and "end" keywords are printed twice on the line. I
> have attached a patch that fixes this.
> 

Have you checked the MI output before and after your patch?


In particular, this bit suggests that in this last chunk you've removed
the 
"good" else/end and left the "bad" ones ;-)
 
> *************** print_command_lines (struct ui_out *uiou
> *** 197,208 ****
>             {
>               if (depth)
>                 ui_out_spaces (uiout, 2 * depth);
> -             ui_out_field_string (uiout, NULL, "else");
>               ui_out_text (uiout, "else\n");
>               print_command_lines (uiout, list->body_list[1], depth + 1);
>             }
> 
> -         ui_out_field_string (uiout, NULL, "end");
>           if (depth)
>             ui_out_spaces (uiout, 2 * depth);
>           ui_out_text (uiout, "end\n");
> --- 194,203 ----

Regards,
Fernando

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9