[RFA/5.1] Update struct breakpoint and struct tracepoint (fwd)

[RFA/5.1] Update struct breakpoint and struct tracepoint (fwd)

[Keith Seitz]

Hi,

I would like to check this into the 5.1 branch. My thanks to Robert
Schiele (rschiele@uni-mannheim.de) for pointing out this omission.

Ok?
Keith
---------- Forwarded message ----------
Date: Thu, 2 Aug 2001 08:39:54 -0700 (PDT)
From: Keith Seitz <keiths@makita.cygnus.com>
To: Insight Maling List <insight@sources.redhat.com>
Subject: [PATCH] Update struct breakpoint and struct tracepoint

FYI

I have checked in the following patch which fixes build errors introduced
yesterday as a result of some breakpoint.h and tracepoint.h cleanups in
gdb.

Keith

ChangeLog
2001-08-02  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-bp.c (gdb_get_breakpoint_info): Update
	with recent breakpoint structure changes in gdb.
	(gdb_set_bp_addr): Likewise.
	(gdb_get_tracepoint_info): Update with recent tracepoint
	structure changes in gdb.

Patch
Index: generic/gdbtk-bp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v
retrieving revision 1.8
diff -u -p -r1.8 gdbtk-bp.c
--- gdbtk-bp.c	2001/06/13 20:01:42	1.8
+++ gdbtk-bp.c	2001/08/02 15:19:23
@@ -343,7 +343,7 @@ gdb_get_breakpoint_info (ClientData clie
   Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr,
 			    Tcl_NewStringObj (bptypes[b->type], -1));
   Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr,
-			    Tcl_NewBooleanObj (b->enable == enabled));
+			    Tcl_NewBooleanObj (b->enable_state == bp_enabled));
   Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr,
 			    Tcl_NewStringObj (bpdisp[b->disposition], -1));
   Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr,
@@ -456,9 +456,9 @@ gdb_set_bp (clientData, interp, objc, ob
       return TCL_ERROR;
     }
   if (strncmp (typestr, "temp", 4) == 0)
-    disp = del;
+    disp = disp_del;
   else if (strncmp (typestr, "normal", 6) == 0)
-    disp = donttouch;
+    disp = disp_donttouch;
   else
     {
       Tcl_SetStringObj (result_ptr->obj_ptr,
@@ -538,9 +538,9 @@ gdb_set_bp_addr (ClientData clientData,
       return TCL_ERROR;
     }
   if (strncmp (typestr, "temp", 4) == 0)
-    disp = del;
+    disp = disp_del;
   else if (strncmp (typestr, "normal", 6) == 0)
-    disp = donttouch;
+    disp = disp_donttouch;
   else
     {
       Tcl_SetStringObj (result_ptr->obj_ptr,
@@ -817,7 +817,7 @@ gdb_get_tracepoint_info (ClientData clie
     free (tmp);
   }
   Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr,
-			    Tcl_NewIntObj (tp->enabled));
+			    Tcl_NewIntObj (tp->enabled_p));
   Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr,
 			    Tcl_NewIntObj (tp->pass_count));
   Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr,

Re: [RFA/5.1] Update struct breakpoint and struct tracepoint (fwd)

[Andrew Cagney]

> Hi,
> 
> I would like to check this into the 5.1 branch. My thanks to Robert
> Schiele (rschiele@uni-mannheim.de) for pointing out this omission.
> 
> Ok?

Yes, fine, since it is Insight related it is really your decision.
This is actually good news.  I've now hard evidence that the `snapshot 
from the branch process' is working.

thanks!
	Andrew

Re: [RFA/5.1] Update struct breakpoint and struct tracepoint (fwd)

[Keith Seitz]

On Tue, 21 Aug 2001, Andrew Cagney wrote:

> > Hi,
> >
> > I would like to check this into the 5.1 branch. My thanks to Robert
> > Schiele (rschiele@uni-mannheim.de) for pointing out this omission.
> >
> > Ok?
>
> Yes, fine, since it is Insight related it is really your decision.
> This is actually good news.  I've now hard evidence that the `snapshot
> from the branch process' is working.

Ok. I just didn't want to blindly start checking things into the branch,
since it really is kinda frozen. Granted, this is more the exception, but
it really is a gdb branch, and we're (insight) just tagging along for the
ride. :-)

Keith