Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Mark Kettenis <kettenis@wins.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH, RFC/RFA]: Drop GDB-private regex implementation
Date: Tue, 21 Aug 2001 06:53:00 -0000	[thread overview]
Message-ID: <3B80A40E.7020508@cygnus.com> (raw)
In-Reply-To: <200108190824.f7J8OOg00489@delius.kettenis.local>

> Here's a patch to drop the GDB-private regex implementation
> (gnu-regex.c, gnu-regex.h) in favor of the recently introduced version
> in libiberty.  Maintaining two versions of (almost) identical code
> seems a waste of resources to me.
> 
> If I don't see any objections in the next two weeks, I'll check this
> in.

Did the POSIX vs BSD(?) regex problem get resolved?  I recall being told 
that GDB was using BSD but libiberty regex was providing POSIX behavour 
(or perhaphs I've got the wrong end of the stick here).

Beyond that, I can't see a reason to not do this.

	Andrew

> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> Make GDB use libiberty regex implementation.
> 	* gdb_regex.h: Normalize protection against multiple inclusion.
> 	Include "xregex.h" instead of "nu-regex.h".
> 	* Makefile.in (REGEX): Remove.
> 	(GDB_CFLAGS): Remove reference to gnu-regex.h in comment.
> 	(ADD_FILES, ADD_DEPS): Remove $(REGEX).
> 	(POSSLIBS): Remove.
> 	(TAGFILES_NO_SRCDIR): Remove $(POSSLIBS).
> 	(irix5-nat.o, solib.o, solib-svr4.o, source.o, symtab.o,
> 	xcoffsolib.o, cli-decode.o, cli-cmd.o): Replace gnu-regex.h with
> 	gdb_regex.h in list of dependencies.
> 	(gnu-regex.o): Remove rule.
> 	(gnu-regex.c, gnu-regex.h): Remove files.
> 
> 



      reply	other threads:[~2001-08-21  6:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-19  1:24 Mark Kettenis
2001-08-21  6:53 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B80A40E.7020508@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@wins.uva.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox