From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: Mark Kettenis <kettenis@wins.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH, RFC/RFA]: Drop GDB-private regex implementation
Date: Tue, 21 Aug 2001 06:53:00 -0000
Message-id: <3B80A40E.7020508@cygnus.com>
References: <200108190824.f7J8OOg00489@delius.kettenis.local>
X-SW-Source: 2001-08/msg00242.html

> Here's a patch to drop the GDB-private regex implementation
> (gnu-regex.c, gnu-regex.h) in favor of the recently introduced version
> in libiberty.  Maintaining two versions of (almost) identical code
> seems a waste of resources to me.
> 
> If I don't see any objections in the next two weeks, I'll check this
> in.

Did the POSIX vs BSD(?) regex problem get resolved?  I recall being told 
that GDB was using BSD but libiberty regex was providing POSIX behavour 
(or perhaphs I've got the wrong end of the stick here).

Beyond that, I can't see a reason to not do this.

	Andrew

> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> Make GDB use libiberty regex implementation.
> 	* gdb_regex.h: Normalize protection against multiple inclusion.
> 	Include "xregex.h" instead of "nu-regex.h".
> 	* Makefile.in (REGEX): Remove.
> 	(GDB_CFLAGS): Remove reference to gnu-regex.h in comment.
> 	(ADD_FILES, ADD_DEPS): Remove $(REGEX).
> 	(POSSLIBS): Remove.
> 	(TAGFILES_NO_SRCDIR): Remove $(POSSLIBS).
> 	(irix5-nat.o, solib.o, solib-svr4.o, source.o, symtab.o,
> 	xcoffsolib.o, cli-decode.o, cli-cmd.o): Replace gnu-regex.h with
> 	gdb_regex.h in list of dependencies.
> 	(gnu-regex.o): Remove rule.
> 	(gnu-regex.c, gnu-regex.h): Remove files.
> 
>