From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa/ppc/branch too] Fix PowerPC/Linux cores
Date: Fri, 03 Aug 2001 08:39:00 -0000 [thread overview]
Message-ID: <3B6AC5A2.7020706@cygnus.com> (raw)
In-Reply-To: <1010802194721.ZM12978@ocotillo.lan>
> On Aug 2, 12:08pm, Daniel Jacobowitz wrote:
>
>
>> Fixing it "right" will be cross corefile support, but changing
>> core-regset is correct for now. If no one objects I'm going to check
>> in the below patch tomorrow, branch and trunk (when is the branch
>> release point supposed to be? Isn't it coming up on us now?).
>>
>> I tested the patch on powerpc-linux, and it works exactly as expected.
>
>
> Your patch looks good to me... (Please note that I'm not the maintainer
> of core-regset.c though.)
I think you two have figured out it's as ok as it can be made ->
``obvious''.
Andrew
>> 2001-08-02 Daniel Jacobowitz <drow@mvista.com>
>>
>> * core-regset.c (fetch_core_registers): Remove HAVE_GREGSET_T
>> and HAVE_FPREGSET_T checks. Use gdb_gregset_t and
>> gdb_fpregset_t.
>>
>> --- gdb-5.0.cvs20010729/gdb/core-regset.c.orig Thu Aug 2 11:26:38 2001
>> +++ gdb-5.0.cvs20010729/gdb/core-regset.c Thu Aug 2 11:27:05 2001
>> @@ -84,9 +84,8 @@
>> fetch_core_registers (char *core_reg_sect, unsigned core_reg_size, int which,
>> CORE_ADDR reg_addr)
>> {
>> -#if defined (HAVE_GREGSET_T) && defined (HAVE_FPREGSET_T)
>> - gregset_t gregset;
>> - fpregset_t fpregset;
>> + gdb_gregset_t gregset;
>> + gdb_fpregset_t fpregset;
>> > if (which == 0)
>> {
>> @@ -113,7 +112,6 @@
>> supply_fpregset (&fpregset);
>> }
>> }
>> -#endif /* defined(HAVE_GREGSET_T) && defined (HAVE_FPREGSET_T) */
>> }
>> \f
>
next prev parent reply other threads:[~2001-08-03 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-30 14:23 Daniel Jacobowitz
2001-07-30 15:44 ` Kevin Buettner
2001-07-30 15:54 ` Daniel Jacobowitz
2001-07-30 17:50 ` Kevin Buettner
2001-07-30 17:57 ` Daniel Jacobowitz
2001-07-31 8:50 ` Andrew Cagney
2001-08-02 12:08 ` Daniel Jacobowitz
2001-08-02 12:48 ` Kevin Buettner
2001-08-03 8:39 ` Andrew Cagney [this message]
2001-08-03 14:36 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B6AC5A2.7020706@cygnus.com \
--to=ac131313@cygnus.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox