From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Kevin Buettner Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [rfa/ppc/branch too] Fix PowerPC/Linux cores Date: Fri, 03 Aug 2001 08:39:00 -0000 Message-id: <3B6AC5A2.7020706@cygnus.com> References: <20010730142328.A6323@nevyn.them.org> <1010730224404.ZM5571@ocotillo.lan> <20010730155455.A3552@nevyn.them.org> <1010731004934.ZM5803@ocotillo.lan> <20010802120808.A3911@nevyn.them.org> <1010802194721.ZM12978@ocotillo.lan> X-SW-Source: 2001-08/msg00065.html > On Aug 2, 12:08pm, Daniel Jacobowitz wrote: > > >> Fixing it "right" will be cross corefile support, but changing >> core-regset is correct for now. If no one objects I'm going to check >> in the below patch tomorrow, branch and trunk (when is the branch >> release point supposed to be? Isn't it coming up on us now?). >> >> I tested the patch on powerpc-linux, and it works exactly as expected. > > > Your patch looks good to me... (Please note that I'm not the maintainer > of core-regset.c though.) I think you two have figured out it's as ok as it can be made -> ``obvious''. Andrew >> 2001-08-02 Daniel Jacobowitz >> >> * core-regset.c (fetch_core_registers): Remove HAVE_GREGSET_T >> and HAVE_FPREGSET_T checks. Use gdb_gregset_t and >> gdb_fpregset_t. >> >> --- gdb-5.0.cvs20010729/gdb/core-regset.c.orig Thu Aug 2 11:26:38 2001 >> +++ gdb-5.0.cvs20010729/gdb/core-regset.c Thu Aug 2 11:27:05 2001 >> @@ -84,9 +84,8 @@ >> fetch_core_registers (char *core_reg_sect, unsigned core_reg_size, int which, >> CORE_ADDR reg_addr) >> { >> -#if defined (HAVE_GREGSET_T) && defined (HAVE_FPREGSET_T) >> - gregset_t gregset; >> - fpregset_t fpregset; >> + gdb_gregset_t gregset; >> + gdb_fpregset_t fpregset; >> > if (which == 0) >> { >> @@ -113,7 +112,6 @@ >> supply_fpregset (&fpregset); >> } >> } >> -#endif /* defined(HAVE_GREGSET_T) && defined (HAVE_FPREGSET_T) */ >> } >> >