[PATCH]: Remove terminal_save_ours() from tui

[PATCH]: Remove terminal_save_ours() from tui

[Stephane Carrez]

Hi!

It was an integration mistake that terminal_save_ours() appeared in tui code.
I've committed this patch on mainline to remove that.  I'll try to put this
patch on the branch too.

	Stephane

2001-07-31  Stephane Carrez  <Stephane.Carrez@worldnet.fr>

	* tui.c (tui_enable): Remove call to terminal_save_ours().
	(tui_disable): Likewise.
Index: tui.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui.c,v
retrieving revision 1.13
diff -u -p -r1.13 tui.c
--- tui.c	2001/07/23 21:13:57	1.13
+++ tui.c	2001/07/31 18:47:53
@@ -240,9 +240,6 @@ tui_enable (void)
   tui_version = 1;
   tui_active = 1;
   refresh ();
-
-  /* Update gdb's knowledge of its terminal.  */
-  terminal_save_ours ();
 }
 
 /* Leave the tui mode.
@@ -265,8 +262,6 @@ tui_disable (void)
      so that terminal management with the inferior works.  */
   tui_setup_io (0);
 
-  /* Update gdb's knowledge of its terminal.  */
-  terminal_save_ours ();
   tui_version = 0;
   tui_active = 0;
 }
From vinschen@redhat.com Tue Jul 31 12:07:00 2001
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: [PATCH]: ser-tcp.c: Use `localhost' as default hostname
Date: Tue, 31 Jul 2001 12:07:00 -0000
Message-id: <20010731210714.A3717@cygbert.vinschen.de>
X-SW-Source: 2001-07/msg00759.html
Content-length: 1063

Hi,

I don't like to type

  target remote localhost:1234

all the time. It"s possible to abbreviate it to

  ta r localhost:1234

but I don't see a need to type `localhost'. I would like to have
`localhost' as default if no hostname is given like in:

  ta r :1234

The following tiny patch handles that.

Corinna

ChangeLog:
==========

2001-07-31  Corinna Vinschen  <vinschen@redhat.com>

	ser-tcp.c (tcp_open): Use `localhost' as default host if no
	hostname is given.

Index: ser-tcp.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-tcp.c,v
retrieving revision 1.6
diff -u -p -r1.6 ser-tcp.c
--- ser-tcp.c	2001/07/11 17:52:32	1.6
+++ ser-tcp.c	2001/07/31 19:00:30
@@ -63,6 +63,9 @@ tcp_open (struct serial *scb, const char
   hostname[tmp] = '\000';	/* Tie off host name */
   port = atoi (port_str + 1);
 
+  if (!hostname[0])
+    strcpy (hostname, "localhost");
+
   hostent = gethostbyname (hostname);
 
   if (!hostent)

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

Re: [PATCH]: Remove terminal_save_ours() from tui

[Stephane Carrez]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

Hi!

Stephane Carrez a écrit :
> 
> Hi!
> 
> It was an integration mistake that terminal_save_ours() appeared in tui code.
> I've committed this patch on mainline to remove that.  I'll try to put this
> patch on the branch too.
> 
>         Stephane
> 
> 2001-07-31  Stephane Carrez  <Stephane.Carrez@worldnet.fr>
> 
>         * tui.c (tui_enable): Remove call to terminal_save_ours().
>         (tui_disable): Likewise.
> 

I've committed this on the branch now.

The TUI should build but the terminal management will not be correct.
This will be solved after 5.1 (I hope).

	Stephane