Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: Colin Walters <walters@cis.ohio-state.edu>,
	gdb-patches@sourceware.cygnus.com
Subject: Re: refcard.dvi build patch
Date: Thu, 05 Jul 2001 21:49:00 -0000	[thread overview]
Message-ID: <3B454352.1080902@cygnus.com> (raw)
In-Reply-To: <Pine.SUN.3.91.1010705094528.15332E-100000@is>

Try the attached?

	Andrew
From ac131313@cygnus.com Thu Jul 05 22:22:00 2001
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips32_next_pc overdue cleanup
Date: Thu, 05 Jul 2001 22:22:00 -0000
Message-id: <3B454B1B.7040506@cygnus.com>
References: <20010704114147.A15695@nevyn.them.org>
X-SW-Source: 2001-07/msg00140.html
Content-length: 823

> This patch is half style cleanups and half obvious fixes, but there's so
> many I'd appreciate more eyes.  According to the masks in the opcodes
> directory, these changes are rigt, and what we had before can't possibly
> work.  Especially the fact that we would never, ever predict a BNE as taken
> before these changes convinced me that they really were correct and this
> code had never been particularly tested.  Comments?


Approved.

History?  It pre-dates my MIPS hacking :-)  Dig dig, ah, it started out 
as part of some prototyping that wasn't finished  It was added in '98. 
The WinCE GDB port ended up using it so I suspect it was made to mostly 
work.  The main reason the code worked is because it didn't bother to 
use the broken macros that were added at the same time as the original 
code :-/

	Andrew



  reply	other threads:[~2001-07-05 21:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87g0ctd2la.church.of.emacs@cis.ohio-state.edu>
     [not found] ` <3B3AABB2.9080708@cygnus.com>
2001-06-27 22:27   ` Colin Walters
2001-06-28  3:41   ` Eli Zaretskii
2001-06-28 23:09     ` Colin Walters
2001-06-29  2:10       ` Eli Zaretskii
2001-07-04 11:25   ` Andrew Cagney
2001-07-04 13:29   ` Andrew Cagney
2001-07-04 23:45     ` Eli Zaretskii
2001-07-05 21:49       ` Andrew Cagney [this message]
2001-07-09  1:21         ` Eli Zaretskii
2001-07-14  9:01           ` Andrew Cagney
2001-07-10 23:13         ` Colin Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B454352.1080902@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=eliz@is.elta.co.il \
    --cc=gdb-patches@sourceware.cygnus.com \
    --cc=walters@cis.ohio-state.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox