From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Eli Zaretskii Cc: Colin Walters , gdb-patches@sourceware.cygnus.com Subject: Re: refcard.dvi build patch Date: Thu, 05 Jul 2001 21:49:00 -0000 Message-id: <3B454352.1080902@cygnus.com> References: X-SW-Source: 2001-07/msg00139.html Try the attached? Andrew >From ac131313@cygnus.com Thu Jul 05 22:22:00 2001 From: Andrew Cagney To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips32_next_pc overdue cleanup Date: Thu, 05 Jul 2001 22:22:00 -0000 Message-id: <3B454B1B.7040506@cygnus.com> References: <20010704114147.A15695@nevyn.them.org> X-SW-Source: 2001-07/msg00140.html Content-length: 823 > This patch is half style cleanups and half obvious fixes, but there's so > many I'd appreciate more eyes. According to the masks in the opcodes > directory, these changes are rigt, and what we had before can't possibly > work. Especially the fact that we would never, ever predict a BNE as taken > before these changes convinced me that they really were correct and this > code had never been particularly tested. Comments? Approved. History? It pre-dates my MIPS hacking :-) Dig dig, ah, it started out as part of some prototyping that wasn't finished It was added in '98. The WinCE GDB port ended up using it so I suspect it was made to mostly work. The main reason the code worked is because it didn't bother to use the broken macros that were added at the same time as the original code :-/ Andrew