Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Remove D10V-specific code from arch-independent modules
Date: Thu, 05 Jul 2001 15:58:00 -0000	[thread overview]
Message-ID: <3B44F118.10601@cygnus.com> (raw)
In-Reply-To: <nplmm3m24x.fsf@zwingli.cygnus.com>

> The convert to/from virtual/raw register functions are borderline 
>> deprecated.  They are being replaced by the much simpler functions 
>> gdbarch_register_{read,write}.  If, for the d10v, those conversion 
>> functions are being eliminated then I'd just delete them.
> 
> 
> The D10V no longer has any convertible registers, so those functions
> certainly should never be called.  I just assumed I'd get a gdbarch
> error if I didn't provide some value for them.  Are you saying I can
> just delete the set_gdbarch_* calls altogether, and the dummy
> functions they register?  (I guess since the corresponding macros are
> optional, that would make sense...)


Yes it can all just go.  Those functions are strictly optional.

   /* Skip verify of register_convertible, invalid_p == 0 */
   /* Skip verify of register_convert_to_virtual, invalid_p == 0 */
   /* Skip verify of register_convert_to_raw, invalid_p == 0 */

If someone was silly enough to add code that blindly called them then:

   if (gdbarch->register_convert_to_virtual == 0)
     internal_error (__FILE__, __LINE__,
                     "gdbarch: gdbarch_register_convert_to_virtual 
invalid");

would kick in.

	Andrew



  reply	other threads:[~2001-07-05 15:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-28 17:06 Jim Blandy
2001-07-04 22:43 ` Andrew Cagney
2001-07-05 15:38   ` Jim Blandy
2001-07-05 15:58     ` Andrew Cagney [this message]
2001-07-09 20:03 David Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B44F118.10601@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox