From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Remove D10V-specific code from arch-independent modules Date: Thu, 05 Jul 2001 15:58:00 -0000 Message-id: <3B44F118.10601@cygnus.com> References: <20010629000735.132405E9CB@zwingli.cygnus.com> <3B43FE67.5000106@cygnus.com> X-SW-Source: 2001-07/msg00124.html > The convert to/from virtual/raw register functions are borderline >> deprecated. They are being replaced by the much simpler functions >> gdbarch_register_{read,write}. If, for the d10v, those conversion >> functions are being eliminated then I'd just delete them. > > > The D10V no longer has any convertible registers, so those functions > certainly should never be called. I just assumed I'd get a gdbarch > error if I didn't provide some value for them. Are you saying I can > just delete the set_gdbarch_* calls altogether, and the dummy > functions they register? (I guess since the corresponding macros are > optional, that would make sense...) Yes it can all just go. Those functions are strictly optional. /* Skip verify of register_convertible, invalid_p == 0 */ /* Skip verify of register_convert_to_virtual, invalid_p == 0 */ /* Skip verify of register_convert_to_raw, invalid_p == 0 */ If someone was silly enough to add code that blindly called them then: if (gdbarch->register_convert_to_virtual == 0) internal_error (__FILE__, __LINE__, "gdbarch: gdbarch_register_convert_to_virtual invalid"); would kick in. Andrew