From: Andrew Cagney <ac131313@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa(arm)/rfc] Eliminate HOST_{FLOAT,DOUBLE,...}_FORMAT
Date: Fri, 29 Jun 2001 08:31:00 -0000 [thread overview]
Message-ID: <3B3C9C03.7000704@cygnus.com> (raw)
In-Reply-To: <5137-Fri29Jun2001120040+0300-eliz@is.elta.co.il>
> To me, the comment doesn't make sense. If sizeof (host long double) ==
>> size of (target long double) and information is still being lost then I
>> think floatformat_* has a bug.
>
>
> You could lose information if the original value's bit pattern is not
> a valid FP number. Does floatformat_to_doublest handle these
> situations 110% correctly? I see at least one FIXME comment in the
> code there.
At present this loss happens randomly depending on the host / target
combination. I would prefer GDB to at least have slightly more
consistent behavour.
The next step would be to ramp up sim/common/sim-fpu.[hc] and use that
for all FP caculations.
--
Anyway, looking at the code, yes there are several nasty errors:
unsigned long mant;
should be ULONGEST so that it fits a 64 bit mantisa and:
dto += ldexp ((double) mant, exponent - mant_bits);
unfortunatly doesn't take a ``long double''.
/* Note that if exponent indicates a NaN, we can't really do anything
useful
(not knowing if the host has NaN's, or how to build one). So it will
end up as an infinity or something close; that is OK. */
sigh.
Andrew
next prev parent reply other threads:[~2001-06-29 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-28 23:04 Andrew Cagney
2001-06-29 5:16 ` Richard Earnshaw
2001-06-29 8:43 ` Andrew Cagney
[not found] ` <5137-Fri29Jun2001120040+0300-eliz@is.elta.co.il>
2001-06-29 8:31 ` Andrew Cagney [this message]
2001-06-29 9:01 ` Eli Zaretskii
2001-06-29 9:12 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B3C9C03.7000704@cygnus.com \
--to=ac131313@cygnus.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox