Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [rfa(arm)/rfc] Eliminate HOST_{FLOAT,DOUBLE,...}_FORMAT
Date: Thu, 28 Jun 2001 23:04:00 -0000	[thread overview]
Message-ID: <3B3C1A5C.3060906@cygnus.com> (raw)

Hello,

The attatched should catch a few eyebrows :-)

The existing GDB tries to be smart about converting host/target floating 
point values - if it thinks that host-float == target-float then it just 
does a move instead of a conversion.

This patch eliminates the short cut.  Instead the conversion is always 
routed through floatformat_{to,from}_doublest().  The most telling 
comment and the reason this will probably catch a few eyebrows can be 
found in i387-tdep.c:

!   /* Avoid call to floatformat_to_doublest if possible to preserve as
!      much information as possible.  */

To me, the comment doesn't make sense.  If sizeof (host long double) == 
size of (target long double) and information is still being lost then I 
think floatformat_* has a bug.

As a side effect it also cleans up the ARM target-float -> 
target->double conversion so that it is more portable (well I think it is).

Comments?  Approval for the ARM part?  I can/should separate the arm 
part out.

	Andrew




             reply	other threads:[~2001-06-28 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-28 23:04 Andrew Cagney [this message]
2001-06-29  5:16 ` Richard Earnshaw
2001-06-29  8:43   ` Andrew Cagney
     [not found] ` <5137-Fri29Jun2001120040+0300-eliz@is.elta.co.il>
2001-06-29  8:31   ` Andrew Cagney
2001-06-29  9:01     ` Eli Zaretskii
2001-06-29  9:12       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B3C1A5C.3060906@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox