From: Andrew Cagney <ac131313@cygnus.com>
To: John Hughes <john@Calva.COM>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: minor fix for i386v-nat.c
Date: Wed, 27 Jun 2001 21:36:00 -0000 [thread overview]
Message-ID: <3B3AB452.9000304@cygnus.com> (raw)
In-Reply-To: <NCBBLMGKIKDGJMEOMNMEMEDEHEAA.john@Calva.COM>
Did anyone ever look at this?
> In i386_insert_aligned_watchpoint the actual address being watched was saved
> in address_loookup. This is fine for aligned watchpoints, the address gdb
> wants to watch is the same as the actual address. For non-aligned
> watchpoints
> we have to ask the hadware to watch up to 3 different addresses. We need to
> remember the address gdb wants to watch so i386_remove_watchpoint knows
> which
> registers to clean up.
>
> Changelog:
>
> 2000-10-30 John Hughes <john@CalvaEDI.COM>
>
> * i386v-nat.c (i386_insert_aligned_watchpoint) save waddr (the
> watched address) in address_lookup[] rather than addr. This allows
> clean removal of non-aligned watchpoints.
>
> Patch (against released gdb-5.0) attached.
>
> --
> John Hughes <john@Calva.COM>,
> CalvaEDI SA. Tel: +33-1-4313-3131
> 66 rue du Moulin de la Pointe, Fax: +33-1-4313-3139
> 75013 PARIS.
>
>
>
> --- i386v-nat.c.orig Wed Dec 8 03:50:38 1999
> +++ i386v-nat.c Sun Oct 29 12:53:16 2000
> @@ -213,7 +213,7 @@
> addr);
>
> /* Record where we came from. */
> - address_lookup[register_number] = addr;
> + address_lookup[register_number] = waddr;
> return 0;
> }
>
>
next parent reply other threads:[~2001-06-27 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <NCBBLMGKIKDGJMEOMNMEMEDEHEAA.john@Calva.COM>
2001-06-27 21:36 ` Andrew Cagney [this message]
2001-06-28 0:47 ` John Hughes
2001-06-28 2:58 ` John Hughes
2001-06-28 3:42 ` Eli Zaretskii
2001-06-28 9:23 ` Andrew Cagney
2001-06-28 3:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B3AB452.9000304@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sourceware.cygnus.com \
--cc=john@Calva.COM \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox