From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: John Hughes Cc: gdb-patches@sourceware.cygnus.com Subject: Re: minor fix for i386v-nat.c Date: Wed, 27 Jun 2001 21:36:00 -0000 Message-id: <3B3AB452.9000304@cygnus.com> References: X-SW-Source: 2001-06/msg00447.html Did anyone ever look at this? > In i386_insert_aligned_watchpoint the actual address being watched was saved > in address_loookup. This is fine for aligned watchpoints, the address gdb > wants to watch is the same as the actual address. For non-aligned > watchpoints > we have to ask the hadware to watch up to 3 different addresses. We need to > remember the address gdb wants to watch so i386_remove_watchpoint knows > which > registers to clean up. > > Changelog: > > 2000-10-30 John Hughes > > * i386v-nat.c (i386_insert_aligned_watchpoint) save waddr (the > watched address) in address_lookup[] rather than addr. This allows > clean removal of non-aligned watchpoints. > > Patch (against released gdb-5.0) attached. > > -- > John Hughes , > CalvaEDI SA. Tel: +33-1-4313-3131 > 66 rue du Moulin de la Pointe, Fax: +33-1-4313-3139 > 75013 PARIS. > > > > --- i386v-nat.c.orig Wed Dec 8 03:50:38 1999 > +++ i386v-nat.c Sun Oct 29 12:53:16 2000 > @@ -213,7 +213,7 @@ > addr); > > /* Record where we came from. */ > - address_lookup[register_number] = addr; > + address_lookup[register_number] = waddr; > return 0; > } > >