PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Daniel Jacobowitz]

A block in solib-svr4.c is #ifdef'd on DT_MIPS_RLD_MAP, which is defined in
"elf/mips.h".  Including that file would probably help.  We could
conditionally include this file based on target, but I just went by other
files in GDB which referenced it and included it always.

How's this patch?

2001-06-08  Daniel Jacobowitz  <drow@mvista.com>
	* solib-svr4.c: Include "elf/mips.h".
	(elf_locate_base): Make DT_MIPS_RLD_MAP block unconditional. 

-- 
Daniel Jacobowitz                           Debian GNU/Linux Developer
Monta Vista Software                              Debian Security Team
From tromey@redhat.com Fri Jun 08 14:09:00 2001
From: Tom Tromey <tromey@redhat.com>
To: Daniel Berlin <dan@cgsoftware.com>
Cc: Per Bothner <per@bothner.com>, Andrew Cagney <ac131313@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: obvious set_cu_language patch
Date: Fri, 08 Jun 2001 14:09:00 -0000
Message-id: <8766e6eke4.fsf@creche.redhat.com>
References: <m24rtrwkfd.fsf@kelso.bothner.com> <3B212FC8.6010801@cygnus.com> <m2pucevgf6.fsf@kelso.bothner.com> <87vgm6snjf.fsf@cgsoftware.com>
X-SW-Source: 2001-06/msg00179.html
Content-length: 1295

>>>>> "Daniel" == Daniel Berlin <dan@cgsoftware.com> writes:

Daniel> Could you please point me to where i can find out what java
Daniel> arrays *are*, so i can make a type structure for them (the new
Daniel> typesystem is a hierarchy of structs, rather than a single
Daniel> type struct.  This means whatever java arrays *are*, can
Daniel> easily be represented and handled, with no fuss or muss).

Java arrays are structures.  You can see the definition in
gcc/libjava/gcj/array.h.  I've appended the relevant bits for your
perusal.

Most instantiations of JArray are actually created at runtime.  Only
primitive arrays are created statically.

Tom

    class __JArray : public java::lang::Object
    {
    protected:
      // This is just a hack to work around a warning emitted by the C++
      // compiler.  We initialize `length' evilly, but it doesn't know
      // that.
      __JArray () : length (0)
      {
      }
    public:
      const jsize length;
      friend jsize JvGetArrayLength (__JArray*);
    };

    template<class T>
    class JArray : public __JArray
    {
      T data[0];
    public:
      friend T* elements<>(JArray<T>& x);
      friend T* elements<>(JArray<T>* x);
      // T* getData() { return data; }
      // T& operator[](jint i) { return data[i]; }
    };

Re: PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Kevin Buettner]

On Jun 8,  2:07pm, Daniel Jacobowitz wrote:

> A block in solib-svr4.c is #ifdef'd on DT_MIPS_RLD_MAP, which is defined in
> "elf/mips.h".  Including that file would probably help.  We could
> conditionally include this file based on target, but I just went by other
> files in GDB which referenced it and included it always.
> 
> How's this patch?

This patch is approved.  Let me know if you need me to check it in for
you.  (I would prefer to see your name added to the MAINTAINERS file
so that you can check it in yourself.)

Kevin

> 
> 2001-06-08  Daniel Jacobowitz  <drow@mvista.com>
> 	* solib-svr4.c: Include "elf/mips.h".
> 	(elf_locate_base): Make DT_MIPS_RLD_MAP block unconditional. 
> 
> -- 
> Daniel Jacobowitz                           Debian GNU/Linux Developer
> Monta Vista Software                              Debian Security Team
> 
> [ text/plain ] :
> 
> 2001-06-08  Daniel Jacobowitz  <drow@mvista.com>
> 	* solib-svr4.c: Include "elf/mips.h".
> 	(elf_locate_base): Make DT_MIPS_RLD_MAP block unconditional.
> 
> Index: gdb/solib-svr4.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/solib-svr4.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 solib-svr4.c
> --- solib-svr4.c	2001/05/04 04:15:27	1.15
> +++ solib-svr4.c	2001/06/08 21:05:02
> @@ -37,6 +37,7 @@
>  #else
>  #include "elf/external.h"
>  #include "elf/common.h"
> +#include "elf/mips.h"
>  #endif
>  
>  #include "symtab.h"
> @@ -623,7 +624,6 @@ elf_locate_base (void)
>  				      (bfd_byte *) x_dynp->d_un.d_ptr);
>  	      return dyn_ptr;
>  	    }
> -#ifdef DT_MIPS_RLD_MAP
>  	  else if (dyn_tag == DT_MIPS_RLD_MAP)
>  	    {
>  	      char *pbuf;
> @@ -637,7 +637,6 @@ elf_locate_base (void)
>  		return 0;
>  	      return extract_unsigned_integer (pbuf, sizeof (pbuf));
>  	    }
> -#endif
>  	}
>      }
>    else /* 64-bit elf */

Re: PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Daniel Jacobowitz]

On Mon, Jun 18, 2001 at 05:28:03PM -0700, Kevin Buettner wrote:
> On Jun 8,  2:07pm, Daniel Jacobowitz wrote:
> 
> > A block in solib-svr4.c is #ifdef'd on DT_MIPS_RLD_MAP, which is defined in
> > "elf/mips.h".  Including that file would probably help.  We could
> > conditionally include this file based on target, but I just went by other
> > files in GDB which referenced it and included it always.
> > 
> > How's this patch?
> 
> This patch is approved.  Let me know if you need me to check it in for
> you.  (I would prefer to see your name added to the MAINTAINERS file
> so that you can check it in yourself.)

I can't check in at the moment, but I'd certainly appreciate being
added to MAINTAINERS - I'm going to be submitting an entire port in the
rapidly approaching future.  I'd appreciate it if you would check this
in; meanwhile, what should I do (besides the copyright assignment,
which is in progress) in order to gain checkin privileges?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Andrew Cagney]

> This patch is approved.  Let me know if you need me to check it in for
> you.  (I would prefer to see your name added to the MAINTAINERS file
> so that you can check it in yourself.)


You could add Daniel to the list of people caught in the paper trail.

Daniel, I'll eventually get an e-mail saying you assignment is done. 
Once that appears I'll follow it up.

	Andrew

Re: PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Kevin Buettner]

On Jun 19, 11:40am, Andrew Cagney wrote:

> You could add Daniel to the list of people caught in the paper trail.

Done.

Re: PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Daniel Jacobowitz]

On Mon, Jun 18, 2001 at 05:28:03PM -0700, Kevin Buettner wrote:
> On Jun 8,  2:07pm, Daniel Jacobowitz wrote:
> 
> > A block in solib-svr4.c is #ifdef'd on DT_MIPS_RLD_MAP, which is defined in
> > "elf/mips.h".  Including that file would probably help.  We could
> > conditionally include this file based on target, but I just went by other
> > files in GDB which referenced it and included it always.
> > 
> > How's this patch?
> 
> This patch is approved.  Let me know if you need me to check it in for
> you.  (I would prefer to see your name added to the MAINTAINERS file
> so that you can check it in yourself.)

Committed, thanks.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer