Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Michael Snyder <msnyder@cygnus.com>
Cc: "Peter.Schauer" <Peter.Schauer@Regent.E-Technik.TU-Muenchen.DE>,
	gdb-patches@sources.redhat.com
Subject: Re: [RFC] if (INNER_THAN (read_sp(), step_sp - 16))
Date: Sat, 16 Jun 2001 09:42:00 -0000	[thread overview]
Message-ID: <3B2B843C.2090807@cygnus.com> (raw)
In-Reply-To: <3B2AB1E7.C32AA591@cygnus.com>

> Well it can't be a (ugh) #ifdef :-)
> 
> 
> Not even to temporarily circumvent a known bug?


Not even to tempoarily circumvent a known bug.

> I understand your objection (multi-arch, if not general
> distaste), but there are lots of ifdefs in infrun.c already...
> 
> FYI, I was thinking along the lines of
> 	(currently_stepping (ecs)
> #ifdef TM_i386SOL2_H
> 	&& !(step_range_end
> 	    && INNER_THAN (read_sp (), (step_sp - 16)))
> #endif
> 	));
> 
> which would preserve the behavior on x86 solaris, while
> protecting the rest of the world until Peter can come up
> with a better implementation.


I honestly think it would be better to revert PeterS's N year old change 
and file a PR.

	Andrew




  reply	other threads:[~2001-06-16  9:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3B2A97C7.52A839FD@cygnus.com>
     [not found] ` <3B2A9EC8.7020106@cygnus.com>
2001-06-15 18:13   ` Michael Snyder
2001-06-16  9:42     ` Andrew Cagney [this message]
2001-06-23  2:33 ` Peter.Schauer
2001-06-25 18:04   ` Michael Snyder
2001-06-25 18:14     ` Michael Snyder
2001-06-27 15:10   ` Michael Snyder
2001-06-29  3:08     ` Peter.Schauer
2001-06-29 14:16       ` Michael Snyder
2001-07-01  5:10         ` Peter.Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B2B843C.2090807@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=Peter.Schauer@Regent.E-Technik.TU-Muenchen.DE \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox