From: Andrew Cagney <ac131313@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Avoid compiler warnings in mips-tdep.c
Date: Thu, 17 May 2001 20:51:00 -0000 [thread overview]
Message-ID: <3B049C2A.5080102@cygnus.com> (raw)
In-Reply-To: <Pine.SUN.3.91.1010517175343.14151F-100000@is>
> Please consider the following patches to mips-tdep.c, to avoid compiler
> warnings and fix one typo in a comment.
>
>
> 2001-05-17 Eli Zaretskii <eliz@is.elta.co.il>
>
> * mips-tdep.c (show_mipsfpu_command): Remove unused variable msg.
> (mips_set_processor_type_command): Remove unused variable j.
> (mips_breakpoint_from_pc): Declare breakpoint instruction
> sequences as unsigned char, to avoid compiler warnings.
Yes, fixes like this one are pretty obvious.
It is only when people introduce things like casts to gag warnings that
I'll start to wonder.
Andrew
PS: Would -Wunused be a good next candidate for -Werror?
next prev parent reply other threads:[~2001-05-17 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-17 7:53 Eli Zaretskii
2001-05-17 20:51 ` Andrew Cagney [this message]
2001-06-04 0:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B049C2A.5080102@cygnus.com \
--to=ac131313@cygnus.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox