From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Avoid compiler warnings in mips-tdep.c Date: Thu, 17 May 2001 20:51:00 -0000 Message-id: <3B049C2A.5080102@cygnus.com> References: X-SW-Source: 2001-05/msg00351.html > Please consider the following patches to mips-tdep.c, to avoid compiler > warnings and fix one typo in a comment. > > > 2001-05-17 Eli Zaretskii > > * mips-tdep.c (show_mipsfpu_command): Remove unused variable msg. > (mips_set_processor_type_command): Remove unused variable j. > (mips_breakpoint_from_pc): Declare breakpoint instruction > sequences as unsigned char, to avoid compiler warnings. Yes, fixes like this one are pretty obvious. It is only when people introduce things like casts to gag warnings that I'll start to wonder. Andrew PS: Would -Wunused be a good next candidate for -Werror?