From: Andrew Cagney <ac131313@cygnus.com>
To: Michael Snyder <msnyder@cygnus.com>
Cc: cagney@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Remote protocol symbol lookup service.
Date: Thu, 10 May 2001 08:33:00 -0000 [thread overview]
Message-ID: <3AFA23D6.1020104@cygnus.com> (raw)
In-Reply-To: <3AF090AE.4D31F3A@cygnus.com>
> Michael Snyder wrote:
>
>>
>> Andrew,
>>
>> I've changed the initial message from "Q" to "q" as you suggested, and
>> I've hexified the filenames and symbol names, so that they are not
>> vulnerable to embedded special characters. If you have a name for the
>> initial message that you would prefer over "qSharedObject", I'm open
>> to suggestions.
The best I can think of is ``qSymbol:'' - an initial empty symbol to get
things started.
As with the other packets, it will need the ``set remote XXXX-packet
enable/disable'' command and logic to detect when it was simply ignored.
If it was ignored ("" vs "OK"), it shouldn't be retried.
Could I also suggest moving the code doing the work in:
> + /* Function to be called whenever a new objfile (shlib) is detected. */
> + static void
> + remote_new_objfile (struct objfile *objfile)
to a separate function and adding a call to it from remote_open_*(). As
far as I know, that will cover all cases
Don't forget the doco.
Andrew
next prev parent reply other threads:[~2001-05-10 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-02 15:15 Michael Snyder
2001-05-02 15:56 ` Michael Snyder
2001-05-03 4:27 ` Jonathan Larmour
2001-05-03 10:09 ` Michael Snyder
2001-05-03 10:24 ` Jonathan Larmour
2001-05-03 10:47 ` Michael Snyder
2001-05-03 11:15 ` Jonathan Larmour
2001-06-06 3:23 ` Andrew Cagney
2001-05-10 8:33 ` Andrew Cagney [this message]
2001-05-10 18:54 ` Michael Snyder
2001-05-11 18:28 ` Andrew Cagney
2001-05-11 18:39 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AFA23D6.1020104@cygnus.com \
--to=ac131313@cygnus.com \
--cc=cagney@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox