From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Michael Snyder Cc: cagney@cygnus.com, gdb-patches@sources.redhat.com Subject: Re: [RFA]: Remote protocol symbol lookup service. Date: Thu, 10 May 2001 08:33:00 -0000 Message-id: <3AFA23D6.1020104@cygnus.com> References: <3AF08427.3522D20E@cygnus.com> <3AF090AE.4D31F3A@cygnus.com> X-SW-Source: 2001-05/msg00154.html > Michael Snyder wrote: > >> >> Andrew, >> >> I've changed the initial message from "Q" to "q" as you suggested, and >> I've hexified the filenames and symbol names, so that they are not >> vulnerable to embedded special characters. If you have a name for the >> initial message that you would prefer over "qSharedObject", I'm open >> to suggestions. The best I can think of is ``qSymbol:'' - an initial empty symbol to get things started. As with the other packets, it will need the ``set remote XXXX-packet enable/disable'' command and logic to detect when it was simply ignored. If it was ignored ("" vs "OK"), it shouldn't be retried. Could I also suggest moving the code doing the work in: > + /* Function to be called whenever a new objfile (shlib) is detected. */ > + static void > + remote_new_objfile (struct objfile *objfile) to a separate function and adding a call to it from remote_open_*(). As far as I know, that will cover all cases Don't forget the doco. Andrew