From: Michael Snyder <msnyder@cygnus.com>
To: Mark Kettenis <kettenis@science.uva.nl>
Cc: ezannoni@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH, RFA] Fix formatting for event-top.h
Date: Fri, 20 Apr 2001 11:01:00 -0000 [thread overview]
Message-ID: <3AE0796A.E2C44449@cygnus.com> (raw)
In-Reply-To: <200104201548.f3KFmbx01555@debye.wins.uva.nl>
Mark Kettenis wrote:
>
> From: Elena Zannoni <ezannoni@cygnus.com>
> Date: Fri, 20 Apr 2001 10:13:26 -0400 (EDT)
>
> Mark Kettenis writes:
> > While lacking some inspiration while writing about free electrons in a
> > magnetic field (the subject of my thesis) I fixed some formatting
> > mistakes in event-top.h. OK to check the attached patch in?
> >
> > Mark
> >
>
> Sure, thanks. Except I like better functions declarations on just one
> line, so I can see all the parameters when I do a grep, but maybe this
> is not compliant with the general rule? A quick look shows that I am
> probably wrong.
>
> Hmm. The GNU coding standards strongly suggest that one should break
> parameter lists if they don't fit on a single line, at least for
> function definitions. Personally I find those long lines very
> distracting when I'm using Emacs with 80 characters per line. So I
> checked it in :-).
I agree with Mark, I like long lines to be broken at a logical point
and the sub-lines neatly indented (rather than wrapping around my
screen at column 79 and beginning in column one).
Michael
prev parent reply other threads:[~2001-04-20 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-20 3:34 Mark Kettenis
2001-04-20 7:13 ` Elena Zannoni
2001-04-20 8:50 ` Mark Kettenis
2001-04-20 11:01 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AE0796A.E2C44449@cygnus.com \
--to=msnyder@cygnus.com \
--cc=ezannoni@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@science.uva.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox