From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Snyder To: Mark Kettenis Cc: ezannoni@cygnus.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH, RFA] Fix formatting for event-top.h Date: Fri, 20 Apr 2001 11:01:00 -0000 Message-id: <3AE0796A.E2C44449@cygnus.com> References: <200104201033.f3KAXFC01200@debye.wins.uva.nl> <15072.17414.113707.440474@kwikemart.cygnus.com> <200104201548.f3KFmbx01555@debye.wins.uva.nl> X-SW-Source: 2001-04/msg00203.html Mark Kettenis wrote: > > From: Elena Zannoni > Date: Fri, 20 Apr 2001 10:13:26 -0400 (EDT) > > Mark Kettenis writes: > > While lacking some inspiration while writing about free electrons in a > > magnetic field (the subject of my thesis) I fixed some formatting > > mistakes in event-top.h. OK to check the attached patch in? > > > > Mark > > > > Sure, thanks. Except I like better functions declarations on just one > line, so I can see all the parameters when I do a grep, but maybe this > is not compliant with the general rule? A quick look shows that I am > probably wrong. > > Hmm. The GNU coding standards strongly suggest that one should break > parameter lists if they don't fit on a single line, at least for > function definitions. Personally I find those long lines very > distracting when I'm using Emacs with 80 characters per line. So I > checked it in :-). I agree with Mark, I like long lines to be broken at a logical point and the sub-lines neatly indented (rather than wrapping around my screen at column 79 and beginning in column one). Michael